Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor create seedlots from trial #5295

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

dwaring87
Copy link
Member

Description

This refactors the client-side code for the create seedlots from trial tool. It replaces all of the callback functions with async/await functions in an attempt to address #5288.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@dwaring87 dwaring87 linked an issue Feb 3, 2025 that may be closed by this pull request
Copy link
Contributor

@afpowell afpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasmueller
Copy link
Member

Check with the clemson limabean database if this branch works for them

@lukasmueller lukasmueller merged commit bbe0963 into master Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating seedlots from a trial function is broken
4 participants