forked from angulardart/angular_components
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch upstream #1
Open
solid-software
wants to merge
505
commits into
solid-software:master
Choose a base branch
from
angulardart:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-button. PiperOrigin-RevId: 244031406
…able, since it will be confusing for screenreader users to be able to tab to an element that doesn't have keyboard or click handles. PiperOrigin-RevId: 244043914
PiperOrigin-RevId: 244055535
…y under OnPush components. -> Moves the "late update" logic in FocusListDirective to _ngZone.runAfterChangesObserved, which unlike _ngZone.onEventDone, will trigger a microtask to ensure the changes are picked up by Angular's change detection. PiperOrigin-RevId: 244056883
PiperOrigin-RevId: 244065836
…to prevent janky sticky behaviour. PiperOrigin-RevId: 244209086
PiperOrigin-RevId: 244243160
PiperOrigin-RevId: 244363472
fix date_input not using dateFormat to parse use the given `dateFormat` to decode the input value. for the following format `dd/mm/yy`, the parser was inversing month and days, `08/12/2018` -> `12/08/2018` Closes #360 PiperOrigin-RevId: 244367402
PiperOrigin-RevId: 244399225
This is especially problematic for opportunities because the material popup being retained causes offering editor to be retained which causes all the accounts we fetch for offering editor to be retained which can be upwards of 20MB for some companies. Also, fix two buggy tests which got exposed by this change. PiperOrigin-RevId: 244420009
…ne.runAfterChangesObserved, which unlike _ngZone.onEventDone, will trigger a microtask to ensure the changes are picked up by Angular's change detection. PiperOrigin-RevId: 244432184
…oller. PiperOrigin-RevId: 244444180
…Tooltip]) max width. Need to display long content source URLs in a tooltip, but they are being cut off due to the ink tooltip max width restriction. PiperOrigin-RevId: 244673016
Before attempting to scroll to or past the end of the content, invokes this callback to dynamically load more cards. If this callback returns a future, the future is awaited before the scroll happens. During this time, the "scrollable-cards" host element will have the class "loading-more", but there are no styles for this class. If the future has the potential to take a long time to complete, it would be a good idea to add a spinner or something to show that work is happening in the background. PiperOrigin-RevId: 244734654
PiperOrigin-RevId: 244734935
…ne.runAfterChangesObserved, which unlike _ngZone.onEventDone, will trigger a microtask to ensure the changes are picked up by Angular's change detection for the [(selected)] binding. PiperOrigin-RevId: 244764600
PiperOrigin-RevId: 244872188
PiperOrigin-RevId: 244875587
This passes the focus on to the proper element inside the component, allowing autoFocus to target the component correctly. PiperOrigin-RevId: 244959730
*** Reason for rollback *** Roll forward with fix for broken application *** Original change description *** Automated g4 rollback of changelist 243324798. *** Reason for rollback *** Breaks application tests *** Original change description *** In accordance with DeferredContentAware best practices Note: the DeferredContentAware container should only mark its content as invisible after any closing animation completes. Contents should be marked as visible before any opening animation begins. The ensures that the content is... *** PiperOrigin-RevId: 245094335
…e detection PiperOrigin-RevId: 245130098
This is needed when a parent component using Material Expansionpanel gives the content to be focused. PiperOrigin-RevId: 245194832
PiperOrigin-RevId: 245195192
…mouse up calls to that users can more easily select text in popups. PiperOrigin-RevId: 245330327
This is being added to support an input controlled listbox. https://www.w3.org/TR/wai-aria-practices-1.1/examples/combobox/aria1.1pattern/listbox-combo.html PiperOrigin-RevId: 245769909
… aware parent. PiperOrigin-RevId: 246071905
…-deep. Without this change, the mixin will not apply to the expected elements unless it is nested inside a selector that already specifies ::ng-deep. PiperOrigin-RevId: 246148980
the input or press the enter key. PiperOrigin-RevId: 246162902
Roll observable dependency
Co-authored-by: Lukasz Kolodziejczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.