Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zero-width space character to escape the @ symbol in doc comments #21

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

danylo-safonov-solid
Copy link
Collaborator

@danylo-safonov-solid danylo-safonov-solid commented Sep 22, 2023

Because of the @ character in doc comments, the links are compiled into mailto elements instead of href.
I added a zero-width space character after after @ in these links so now it compiles properly

@danylo-safonov-solid danylo-safonov-solid marked this pull request as ready for review September 22, 2023 19:45
Copy link
Contributor

@illia-romanenko illia-romanenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@illia-romanenko illia-romanenko merged commit e758aa1 into main Sep 22, 2023
1 check passed
@illia-romanenko illia-romanenko deleted the fix-docs branch September 22, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants