Fix improper super calls in proper_super_calls.dart and add Disposabl…

…e interface in proper_super_calls_test.dart (#160) * Fix improper super calls in proper_super_calls.dart and add Disposable interface in proper_super_calls_test.dart * Added a comment that abstract methods should be omitted in proper_super_alls
solid-software · Apr 18, 2024 · 133f96c · 133f96c
1 parent cc9825e
commit 133f96c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/src/lints/proper_super_calls/proper_super_calls_rule.dart b/lib/src/lints/proper_super_calls/proper_super_calls_rule.dart
@@ -89,9 +89,11 @@ class ProperSuperCallsRule extends SolidLintRule {
     context.registry.addMethodDeclaration(
       (node) {
         final methodName = node.name.toString();
+        final body = node.body;
 
-        if (methodName == _initState || methodName == _dispose) {
-          final statements = (node.body as BlockFunctionBody).block.statements;
+        if (methodName case _initState || _dispose
+            when body is BlockFunctionBody) {
+          final statements = body.block.statements;
 
           _checkSuperCalls(
             node,

diff --git a/lint_test/proper_super_calls_test.dart b/lint_test/proper_super_calls_test.dart
@@ -75,3 +75,8 @@ class MyClass {
   dispose() {}
   initState() {}
 }
+
+abstract interface class Disposable {
+  /// Abstract methods should be omitted by `proper_super_calls`
+  void dispose();
+}