Avoid-late ignored_types tests

solid-software · Nov 17, 2023 · 2037550 · 2037550
1 parent 8167c07
commit 2037550
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 10 deletions.
diff --git a/lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart b/lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart
@@ -54,7 +54,7 @@ class AvoidLateKeywordRule extends SolidLintRule<AvoidLateKeywordParameters> {
     final hasInitializer = node.initializer != null;
     return !hasInitializer;
   }
-
+  
   bool _hasIgnoredType(VariableDeclaration node) {
     final ignoredTypes = config.parameters.ignoredTypes.toSet();
     if (ignoredTypes.isEmpty) return false;

diff --git a/lint_test/avoid_late_keyword_allow_initialized_test/analysis_options.yaml b/lint_test/avoid_late_keyword_allow_initialized_test/analysis_options.yaml
@@ -6,3 +6,5 @@ custom_lint:
   rules:
     - avoid_late_keyword:
       allow_initialized: false
+      ignored_types:
+        - Animation
diff --git a/.../avoid_late_keyword_allow_initialized_test/avoid_late_keyword_allow_initialized_test.dart b/.../avoid_late_keyword_allow_initialized_test/avoid_late_keyword_allow_initialized_test.dart
@@ -1,8 +1,6 @@
 // ignore_for_file: prefer_const_declarations, unused_local_variable, prefer_match_file_name
 // ignore_for_file: avoid_global_state
 
-import 'package:flutter/material.dart';
-
 /// Check "late" keyword fail
 ///
 /// `avoid_late_keyword`
@@ -22,7 +20,7 @@ class AvoidLateKeyword {
   void test() {
     /// expect_lint: avoid_late_keyword
     late final ColorTween colorTween;
-
+    
     late final AnimationController controller2;
 
     /// expect_lint: avoid_late_keyword
@@ -32,3 +30,9 @@ class AvoidLateKeyword {
     late String field4;
   }
 }
+
+abstract class Animation {}
+
+class AnimationController implements Animation {}
+
+class ColorTween {}
diff --git a/lint_test/avoid_late_keyword_allow_initialized_test/pubspec.yaml b/lint_test/avoid_late_keyword_allow_initialized_test/pubspec.yaml
@@ -5,8 +5,6 @@ environment:
   sdk: '>=3.0.0 <4.0.0'
 
 dependencies:
-  flutter:
-    sdk: flutter
 
 dev_dependencies:
   solid_lints:

diff --git a/lint_test/avoid_late_keyword_test.dart b/lint_test/avoid_late_keyword_test.dart
@@ -20,14 +20,14 @@ class AvoidLateKeyword {
 
   late final SubAnimationController controller2;
 
-  /// expect_lint: avoid_late_keyword
-  late final NotAllowed na;
-
   late final field1 = 'string';
 
-  /// expect_lint: avoid_late_keyword
+   /// expect_lint: avoid_late_keyword
   late String field2;
 
+  /// expect_lint: avoid_late_keyword
+  late final NotAllowed na;
+
   void test() {
     late final ColorTween colorTween;