remove (.length <= 2) limit

solid-software · Mar 29, 2024 · 77579a8 · 77579a8
1 parent c8fec9f
commit 77579a8
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/lib/src/lints/prefer_early_return/visitors/prefer_early_return_visitor.dart b/lib/src/lints/prefer_early_return/visitors/prefer_early_return_visitor.dart
@@ -26,9 +26,6 @@ class PreferEarlyReturnVisitor extends RecursiveAstVisitor<void> {
 
     if (!(nextStatementIsEmptyReturn || nextStatementIsNull)) return;
 
-    // limit to only handling cases with two ifs
-    if (ifStatements.length > 2) return;
-
     _handleIfStatement(ifStatements.last);
   }
 

diff --git a/lint_test/prefer_early_return_test.dart b/lint_test/prefer_early_return_test.dart
@@ -210,3 +210,28 @@ void twoSeqentialIfSomething2() {
     _doSomething();
   }
 }
+
+void threeSeqentialIfReturn() {
+  //no lint
+  if (false) return;
+  if (true) return;
+  //expect_lint: prefer_early_return
+  if (true) {
+    _doSomething();
+  }
+
+  return;
+}
+
+void threeSeqentialIfReturn2() {
+  //no lint
+  if (false) return;
+  //no lint
+  if (true) {
+    _doSomething();
+  }
+  //expect_lint: prefer_early_return
+  if (true) {
+    _doSomething();
+  }
+}