Skip to content

Commit

Permalink
fix more comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sufftea committed May 2, 2024
1 parent 294157e commit b94a8fc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- add exclude params support to avoid_returning_widgets rule (https://github.com/solid-software/solid_lints/issues/131)
- add quick fix to avoid_final_with_getter (https://github.com/solid-software/solid_lints/pull/164)
- Renamed `avoid_debug_print` to `avoid_debug_print_in_release`
- Now, `avoid_debug_print_in_release` doesn't trigger if the `debugPrint` call is wrapped in a `!kReleaseMode` check.
- The `avoid_debug_print_in_release` no longer reports a warning if the `debugPrint` call is wrapped in a `!kReleaseMode` check.

## 0.1.5

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import 'package:custom_lint_builder/custom_lint_builder.dart';
import 'package:solid_lints/src/models/rule_config.dart';
import 'package:solid_lints/src/models/solid_lint_rule.dart';

/// A `avoid_debug_print` rule which forbids calling or referencing
/// debugPrint function in release mode.
/// An `avoid_debug_print_in_release` rule which forbids calling or referencing
/// debugPrint function from flutter/foundation in release mode.
///
/// See more here: https://github.com/flutter/flutter/issues/147141
///
Expand Down Expand Up @@ -50,7 +50,9 @@ class AvoidDebugPrintInReleaseRule extends SolidLintRule {
final rule = RuleConfig(
configs: configs,
name: lintName,
problemMessage: (_) => "Avoid using 'debugPrint' in release mode",
problemMessage: (_) => """
Avoid using 'debugPrint' in release mode. Wrap
your `debugPrint` call in a `!kReleaseMode` check.""",
);

return AvoidDebugPrintInReleaseRule._(rule);
Expand Down

0 comments on commit b94a8fc

Please sign in to comment.