Fix avoid-late if initialized #71

maxxlab · 2023-11-15T14:08:56Z

No description provided.

lint_test/avoid_late_keyword_test.dart

lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart

Co-authored-by: Yurii Prykhodko <[email protected]>

yurii-prykhodko-solid

The issue in question calls for customization, meaning we need to read configs from resolved yaml and allow/disallow initialized late variables dynamically.

Co-authored-by: Yurii Prykhodko <[email protected]>

lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart

lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart

lint_test/analysis_options.yaml

Co-authored-by: Yurii Prykhodko <[email protected]>

lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart

yurii-prykhodko-solid

almost there

…ers.dart Co-authored-by: Yurii Prykhodko <[email protected]>

lib/lints/avoid_late_keyword/models/_config_parser.dart

yurii-prykhodko-solid · 2023-11-16T12:33:33Z

lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart

+      config.parameters.ignoredTypes.contains(
+        // ignore: deprecated_member_use
+        node.declaredElement2?.type.getDisplayString(withNullability: false),


Is there a way to solve this without using deprecated APIs?
Also, this checks for exact match, not subtypes.

lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart

…ers.dart Co-authored-by: Yurii Prykhodko <[email protected]>

…_lints into avoid_late_feature

lint_test/avoid_late_keyword_allow_initialized_test/pubspec.yaml

yurii-prykhodko-solid · 2023-11-16T16:18:08Z

lint_test/avoid_late_keyword_allow_initialized_test/pubspec.yaml

+  flutter:
+    sdk: flutter


You can declare your own classes with same names for test purpose instead of pulling in the entire Flutter SDK as a dependency. See https://github.com/solid-software/solid_lints/pull/74/files#diff-f77bef8e8287cf15cac0245e3c6046109cd594bb0238e8bb61c991070521ab47

lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart

Co-authored-by: Yurii Prykhodko <[email protected]>

…ers.dart Co-authored-by: Yurii Prykhodko <[email protected]>

lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart

Allow subclasses for avoid-late whitelist

Short-circuit if there are no ignored types

lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart

Co-authored-by: Yurii Prykhodko <[email protected]>

yurii-prykhodko-solid

Just a little more

yurii-prykhodko-solid · 2023-11-17T08:59:24Z

...est/avoid_late_keyword_allow_initialized_test/avoid_late_keyword_allow_initialized_test.dart

+// ignore_for_file: prefer_const_declarations, unused_local_variable, prefer_match_file_name
+// ignore_for_file: avoid_global_state
+
+import 'package:flutter/material.dart';


Remove Flutter SDK dependency.

yurii-prykhodko-solid · 2023-11-17T09:00:01Z

lint_test/avoid_late_keyword_allow_initialized_test/pubspec.yaml

+  flutter:
+    sdk: flutter


Suggested change

flutter:

sdk: flutter

Yes, I did it yesterday but create PR only today

yurii-prykhodko-solid · 2023-11-17T09:00:50Z

lint_test/avoid_late_keyword_test.dart

 /// Check "late" keyword fail
 ///
 /// `avoid_late_keyword`
+/// allow_initialized option enabled


Let's also test allow_initialized == false + ignored types.

…_lints into avoid_late_feature

yurii-prykhodko-solid

LGTM, great work!

* Bump version to `0.1.0` * Pull changes from `solid-metrics` repository * Update .gitignore Co-authored-by: Yuri Prykhodko <[email protected]> * Update example/lib/solid_lints_example.dart Co-authored-by: Yuri Prykhodko <[email protected]> * Update `CHANGELOG.md` * Add code checks with GitHub Actions * Add support for the number of parameters metric * Remove DCM references * Change lint message * Simplify configuration and remove redundant code * Fix code comments * Add missing tests * Add `lines_of_code` lint * Fix rule name * Add test and fix an edge case * Update lint to match the specification * Add `avoid_non_null_assertion` lint * Add missing comment * Add `avoid_late_keyword` lint * Update problem message * Add `avoid_global_state` lint * Fix failing tests * Add `avoid_returning_widgets` lint * Use pattern-matching * Simplify `isWidgetReturned` * Update lib/lints/avoid_returning_widgets/avoid_returning_widgets_rule.dart Co-authored-by: Yuri Prykhodko <[email protected]> * Cleanup of `getLintRules` * Fix comment * rename MetricRule -> RuleConfig * add a sceleton for the double-literal-format rule * implement the double-literal-format rule * fix review warnings * implement quick-fix for the double-literal-format rule * fix lint warnings * add avoid-unnecessary-type-assertions rule ('is' part) * fix lint warning * add avoid-unnecessary-type-assertions rule ('whereType' part) * add quick-fix for unnecessary operator is * add quick-fix for unnecessary whereType * fix review warnings; fix a bug * add utility class for type chekcking methods * add constants for is and whereType names * add needed comments * rewrite _isUnnecessaryWhereType with pattern matching * rewrite _areGenericsWithSameTypeArgs with pattern matching * refactoring: move a castTypeInHierarchy to TypeCast class * implement "avoid unnecessary setstate" rule (#44) * implement "avoid unnecessary setstate" rule * fix pr comments * added idea files to gitignore * fix pr comments * Fix merge conflict * Fix tests and improve GitHub workflow * Fix workflow file * Fix conflicts after merge * Remove non-existing import * Add missing rule to tests and remove unnecessary GitHub actions step --------- Co-authored-by: Yaroslav Laptiev <[email protected]> Co-authored-by: vladimir-beloded <[email protected]> * Add avoid_unnecessary_type_casts_rule * Refactor types_utils, extract common methods * Add fix for avoid_unnecessary_type_casts_rule * Add AvoidUnnecessaryTypeCastsRule.createRule to solid_lints.dart * Fix 'quickFix' for avoid-unnecessary-type-casts * Add tests for avoid-unnecessary-type-casts * Fix formatting * Add more test cases * Group code for more readability * Switch to getters, refactor areGenericsWithSameTypeArgs * Avoid unrelated type assertions (#48) * Add avoid-unrelated-type-assertions rule * Add tests for avoid-unrelated-type-assertions rule --------- Co-authored-by: Denis Bogatirov <[email protected]> * Feature/newline before return (#52) * Add newline-before-return rule * Fix typos, remove unnecessary negation * Add tests for newline-before-return --------- Co-authored-by: Denis Bogatirov <[email protected]> * Fixes Issue #54 multiple rule reporting (#55) * Fix newline-before-return * Fix avoid-unrelated-type-assertions * Fix avoid-unnecessary-type-casts --------- Co-authored-by: Denis Bogatirov <[email protected]> * Feature/no empty block (#53) * Add no-empty-block rule * Add tests no-empty-block rule * Add cyclomatic tests case, fix formatting --------- Co-authored-by: Denis Bogatirov <[email protected]> * Add no equal then else rule (#56) * Add no-equal-then-else rule * Add tests for no-equal-then-else rule --------- Co-authored-by: Denis Bogatirov <[email protected]> * Feature/member ordering (#51) * Add required models for member-ordering rule * Add member-ordering rule * Add MIT License comments * Fix parser type mismatch * Add tests for member-ordering and enable rule * Organize imports, ignore member-ordering in unrelated test * Group *_member_group.dart into one directory * Add more test cases * Add more test cases * Add alphabetize test cases * Add tests for alphabetical-by-type option * Ignore no-empty-block in test * Ignore member-ordering in test --------- Co-authored-by: Denis Bogatirov <[email protected]> * Add avoid unused parameters rule (#49) * Add avoid-unused-parameters rule * Add tests for avoid-unused-parameters rule * Fix function name, remove null check operator and remove negation * Fix multiple reporting * Add more test cases * Fix formatting * Rename method * Add constructors and factories unused params handling * Fix constructors with named field parameters * Simplify rule run method * Fix tests * Fix tests after merge * Fix tests after merge --------- Co-authored-by: Denis Bogatirov <[email protected]> * Added no magic number rule (#57) * Add no-magic-number rule * Add tests for no-magic-number rule * Fix import lost in merge * Ignore no-magic-number in test --------- Co-authored-by: Denis Bogatirov <[email protected]> * Added prefer condtional expressions rule and fix (#59) * Add prefer-conditional-expressions rule and fix * Add tests for prefer-conditional-expressions rule * fix nested test plugin path * Fix tests after merge * Update lint_test/prefer_conditional_expressions_ignore_nested_test/prefer_conditional_expressions_ignore_nested_test.dart --------- Co-authored-by: Denis Bogatirov <[email protected]> Co-authored-by: Yurii Prykhodko <[email protected]> * Added prefer first rule (#60) * Add prefer-conditional-expressions rule and fix * Add tests for prefer-conditional-expressions rule * fix nested test plugin path * Fix tests after merge * Add prefer-first rule and fix * Add tests for prefer-first rule --------- Co-authored-by: Denis Bogatirov <[email protected]> Co-authored-by: Yurii Prykhodko <[email protected]> * Add prefer last rule (#61) * Add prefer-conditional-expressions rule and fix * Add tests for prefer-conditional-expressions rule * fix nested test plugin path * Fix tests after merge * Add prefer-first rule and fix * Add tests for prefer-first rule * Add prefer-last rule & fix * Add tests for prefer-last rule --------- Co-authored-by: Denis Bogatirov <[email protected]> Co-authored-by: Yurii Prykhodko <[email protected]> * Add prefer match file name (#62) * Add prefer-conditional-expressions rule and fix * Add tests for prefer-conditional-expressions rule * fix nested test plugin path * Fix tests after merge * Add prefer-first rule and fix * Add tests for prefer-first rule * Add prefer-last rule & fix * Add tests for prefer-last rule * Add prefer-match-file-name rule * Add tests for prefer-match-file-name rule * Typos, naming * Typos, naming * rm todo comment * Update lint_test/prefer_match_file_name_test.dart * Update lint_test/prefer_match_file_name_test.dart --------- Co-authored-by: Denis Bogatirov <[email protected]> Co-authored-by: Yurii Prykhodko <[email protected]> Co-authored-by: Yurii Prykhodko <[email protected]> * Rename custom lints to use snake_case (#66) * Rename custom lints to use snake_case * Rename missed parameter --------- Co-authored-by: vladimir-beloded <[email protected]> * Take into account the constructor initializer in the avoid_unused_parameters rule (#67) Co-authored-by: vladimir-beloded <[email protected]> * Fix linter issues * Bump custom_lint_builder version * Update LICENSE to include third party code license * Allow magic numbers for default values (#72) * Allow magic numbers for default values * More tests --------- Co-authored-by: vladimir-beloded <[email protected]> * Ignore magic number in constructor initializer (#73) * Ignore magic number in constructor initializer * Minor naming improvement --------- Co-authored-by: vladimir-beloded <[email protected]> * Remove DCM steps from readme * Fix avoid-late if initialized (#71) * Implement proper-super-calls (#77) * Fix avoid-late if initialized * Update lint_test/avoid_late_keyword_test.dart Co-authored-by: Yurii Prykhodko <[email protected]> * Apply suggestions from code review Co-authored-by: Yurii Prykhodko <[email protected]> * Custom avoid-late * Fix naming * Apply suggestions from code review Co-authored-by: Yurii Prykhodko <[email protected]> * Avoid late simplified * Update lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart Co-authored-by: Yurii Prykhodko <[email protected]> * Avoid-late ignored_types * Avoid-late ignored_types formatted * Update lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart Co-authored-by: Yurii Prykhodko <[email protected]> * Avoid-late ignored_types fix * Avoid-late ignored_types Fix * Avoid-late allow_initialized testcases * Update lint_test/avoid_late_keyword_allow_initialized_test/pubspec.yaml Co-authored-by: Yurii Prykhodko <[email protected]> * Update lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart Co-authored-by: Yurii Prykhodko <[email protected]> * Allow subclasses for avoid-late whitelist * Fix naming * Short-circuit of there's no ignored types * Short-circuit earlier * Update lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart Co-authored-by: Yurii Prykhodko <[email protected]> * Avoid-late ignored_types tests * Avoid-late add testcases * Proper-super-calls impl * Proper-super-calls format * Apply suggestions from code review Co-authored-by: Yurii Prykhodko <[email protected]> * Proper-super-calls refactoring * Update lib/lints/proper_super_calls/proper_super_calls_rule.dart Co-authored-by: Yurii Prykhodko <[email protected]> * Proper-super-keyword annotation check * Proper-super-keyword format * Proper-super-calls cleanup --------- Co-authored-by: Yurii Prykhodko <[email protected]> Co-authored-by: Yurii Prykhodko <[email protected]> * Ignore magic numbers in widget parameters (#74) * Ignore magic numbers in widget parameters * Add lint parameter to ignore magic numbers in widget params * Improve the allowed_in_widget_params parameter to exclude magic numbers in nested objects of Widget parameters * Add tests for disabled allowed_in_widget_params lint parameter * Remove unnecessary dependency --------- Co-authored-by: vladimir-beloded <[email protected]> * Set default severity level to warning (#78) Co-authored-by: vladimir-beloded <[email protected]> --------- Co-authored-by: Nikodem Bernat <[email protected]> Co-authored-by: Vadym Khokhlov <[email protected]> Co-authored-by: Yaroslav <[email protected]> Co-authored-by: Yaroslav Laptiev <[email protected]> Co-authored-by: vladimir-beloded <[email protected]> Co-authored-by: Denis Bogatirov <[email protected]> Co-authored-by: DenisBogatirov <[email protected]> Co-authored-by: Yurii Prykhodko <[email protected]> Co-authored-by: solid-vovabeloded <[email protected]> Co-authored-by: Illia Romanenko <[email protected]> Co-authored-by: maxxlab <[email protected]>

Fix avoid-late if initialized

da4b854

yurii-prykhodko-solid reviewed Nov 15, 2023

View reviewed changes

lint_test/avoid_late_keyword_test.dart Outdated Show resolved Hide resolved

yurii-prykhodko-solid reviewed Nov 15, 2023

View reviewed changes

lint_test/avoid_late_keyword_test.dart Outdated Show resolved Hide resolved

yurii-prykhodko-solid requested changes Nov 15, 2023

View reviewed changes

lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart Outdated Show resolved Hide resolved

Update lint_test/avoid_late_keyword_test.dart

f5f5bf2

Co-authored-by: Yurii Prykhodko <[email protected]>

yurii-prykhodko-solid requested changes Nov 15, 2023

View reviewed changes

maxxlab and others added 3 commits November 15, 2023 16:19

Apply suggestions from code review

e34f822

Co-authored-by: Yurii Prykhodko <[email protected]>

Custom avoid-late

2633fc9

Fix naming

f5a4a81

yurii-prykhodko-solid requested changes Nov 15, 2023

View reviewed changes

lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart Outdated Show resolved Hide resolved

lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart Outdated Show resolved Hide resolved

lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart Outdated Show resolved Hide resolved

yurii-prykhodko-solid reviewed Nov 15, 2023

View reviewed changes

lint_test/analysis_options.yaml Outdated Show resolved Hide resolved

maxxlab and others added 2 commits November 15, 2023 18:08

Apply suggestions from code review

78eef07

Co-authored-by: Yurii Prykhodko <[email protected]>

Avoid late simplified

8aeeeb2

yurii-prykhodko-solid reviewed Nov 15, 2023

View reviewed changes

lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart Outdated Show resolved Hide resolved

yurii-prykhodko-solid reviewed Nov 15, 2023

View reviewed changes

lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart Outdated Show resolved Hide resolved

yurii-prykhodko-solid requested changes Nov 15, 2023

View reviewed changes

maxxlab and others added 2 commits November 15, 2023 19:29

Update lib/lints/avoid_late_keyword/models/avoid_late_keyword_paramet…

13b5e61

…ers.dart Co-authored-by: Yurii Prykhodko <[email protected]>

Avoid-late ignored_types

83629fe

yurii-prykhodko-solid requested changes Nov 16, 2023

View reviewed changes

Avoid-late ignored_types formatted

13a6d16

yurii-prykhodko-solid reviewed Nov 16, 2023

View reviewed changes

lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart Outdated Show resolved Hide resolved

maxxlab and others added 5 commits November 16, 2023 14:47

Update lib/lints/avoid_late_keyword/models/avoid_late_keyword_paramet…

56abdb6

…ers.dart Co-authored-by: Yurii Prykhodko <[email protected]>

Avoid-late ignored_types fix

6315eca

Merge branch 'avoid_late_feature' of https://github.com/maxxlab/solid…

78246e9

…_lints into avoid_late_feature

Avoid-late ignored_types Fix

dbd6bdf

Avoid-late allow_initialized testcases

d215871

yurii-prykhodko-solid requested changes Nov 16, 2023

View reviewed changes

maxxlab and others added 3 commits November 16, 2023 18:44

Update lint_test/avoid_late_keyword_allow_initialized_test/pubspec.yaml

f639d91

Co-authored-by: Yurii Prykhodko <[email protected]>

Update lib/lints/avoid_late_keyword/models/avoid_late_keyword_paramet…

850cfaa

…ers.dart Co-authored-by: Yurii Prykhodko <[email protected]>

Allow subclasses for avoid-late whitelist

b426d49

yurii-prykhodko-solid reviewed Nov 16, 2023

View reviewed changes

lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart Outdated Show resolved Hide resolved

solid-yuriiprykhodko and others added 5 commits November 16, 2023 19:20

Fix naming

b023b8c

Merge pull request #1 from yurii-prykhodko-solid/ignore-late-subclasses

b4fe907

Allow subclasses for avoid-late whitelist

Short-circuit of there's no ignored types

662dc49

Short-circuit earlier

41fe9ab

Merge pull request #2 from yurii-prykhodko-solid/ignore-late-subclasses

8167c07

Short-circuit if there are no ignored types

yurii-prykhodko-solid reviewed Nov 17, 2023

View reviewed changes

lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart Outdated Show resolved Hide resolved

Update lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart

fbf2270

Co-authored-by: Yurii Prykhodko <[email protected]>

yurii-prykhodko-solid requested changes Nov 17, 2023

View reviewed changes

maxxlab added 3 commits November 17, 2023 11:02

Avoid-late ignored_types tests

2037550

Merge branch 'avoid_late_feature' of https://github.com/maxxlab/solid…

e3a85fa

…_lints into avoid_late_feature

Avoid-late add testcases

bb69baa

yurii-prykhodko-solid approved these changes Nov 17, 2023

View reviewed changes

yurii-prykhodko-solid merged commit 6aae62c into solid-software:release-v0.1.0 Nov 17, 2023
1 check passed

maxxlab deleted the avoid_late_feature branch November 17, 2023 10:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix avoid-late if initialized #71

Fix avoid-late if initialized #71

maxxlab commented Nov 15, 2023

yurii-prykhodko-solid left a comment

yurii-prykhodko-solid left a comment

yurii-prykhodko-solid Nov 16, 2023

yurii-prykhodko-solid Nov 16, 2023

yurii-prykhodko-solid left a comment

yurii-prykhodko-solid Nov 17, 2023

yurii-prykhodko-solid Nov 17, 2023

maxxlab Nov 17, 2023

yurii-prykhodko-solid Nov 17, 2023

yurii-prykhodko-solid left a comment

Fix avoid-late if initialized #71

Fix avoid-late if initialized #71

Conversation

maxxlab commented Nov 15, 2023

yurii-prykhodko-solid left a comment

Choose a reason for hiding this comment

yurii-prykhodko-solid left a comment

Choose a reason for hiding this comment

yurii-prykhodko-solid Nov 16, 2023

Choose a reason for hiding this comment

yurii-prykhodko-solid Nov 16, 2023

Choose a reason for hiding this comment

yurii-prykhodko-solid left a comment

Choose a reason for hiding this comment

yurii-prykhodko-solid Nov 17, 2023

Choose a reason for hiding this comment

yurii-prykhodko-solid Nov 17, 2023

Choose a reason for hiding this comment

maxxlab Nov 17, 2023

Choose a reason for hiding this comment

yurii-prykhodko-solid Nov 17, 2023

Choose a reason for hiding this comment

yurii-prykhodko-solid left a comment

Choose a reason for hiding this comment