Skip to content

Updates tauri-storage for Tauri 2 stable #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bpevs
Copy link

@bpevs bpevs commented Apr 25, 2025

The api for plugin-store has changed since the last commit.
This pr updates that, and allows for passing store options obj.

Copy link

changeset-bot bot commented Apr 25, 2025

⚠️ No Changeset found

Latest commit: 08167dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@atk
Copy link
Member

atk commented Apr 25, 2025

There might still be projects using v1, so I would prefer to split the module.

@bpevs
Copy link
Author

bpevs commented Apr 26, 2025

oh this is meant to be compatible with v1? I didn't realize the apis were exactly the same; the example app uses 2.0-beta. To be clear, thr changes I was meaning to address were the api changes between tauri 2.0-alpha and tauri 2.0 stable.

edit:
I think the first version of @tauri-apps/plugin-store was already targeted at 2.0-alpha:
https://www.npmjs.com/package/@tauri-apps/plugin-store/v/2.0.0-alpha.0

@atk
Copy link
Member

atk commented Apr 26, 2025

No, it's just that support for both is on my to-do list.

@bpevs
Copy link
Author

bpevs commented Apr 26, 2025

Okie. Mmmm If you want me to format/split this in a particular way, I don't mind making a few changes to help. But I'm not sure on your preferences on how to split, and with this small amount of code, I feel like the communication might be more work than just making the actual edits.

So feel free to directly edit/close/do whatever with this pr, if it's easier. I was just making the pr since I had already made these updates locally to support my app.

@atk
Copy link
Member

atk commented Apr 26, 2025

I had not yet decided whether to call the sub-modules tauri-v2/-v1 or tauri/-legacy or transparently support both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants