-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Auto-populate page field when reporting an issue #1051
Open
bertday
wants to merge
30
commits into
solidjs:main
Choose a base branch
from
bertday:iss-1049
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−1
Open
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
0743679
fix: Make "Report an issue" link open in new tab
bertday 69a3f9a
chore: Clean up whitespace in page-issue-link classes
bertday bf08606
feat: Auto-populate page field when reporting an issue
bertday 10124c2
Merge branch 'main' into iss-1049
kodiakhq[bot] 059f2e5
Merge branch 'main' into iss-1049
kodiakhq[bot] be72882
Merge branch 'main' into iss-1049
kodiakhq[bot] 1fada80
Merge branch 'main' into iss-1049
kodiakhq[bot] 4e23f90
Merge branch 'main' into iss-1049
kodiakhq[bot] b77828b
Merge branch 'main' into iss-1049
kodiakhq[bot] 740b7c8
Merge branch 'main' into iss-1049
kodiakhq[bot] 71008c6
Merge branch 'main' into iss-1049
kodiakhq[bot] e209677
Merge branch 'main' into iss-1049
kodiakhq[bot] e4eaed9
Merge branch 'main' into iss-1049
kodiakhq[bot] 8763095
Merge branch 'main' into iss-1049
kodiakhq[bot] da20136
Merge branch 'main' into iss-1049
kodiakhq[bot] f135ca3
Merge branch 'main' into iss-1049
kodiakhq[bot] ca19dd5
Merge branch 'main' into iss-1049
kodiakhq[bot] 0ba2e65
Merge branch 'main' into iss-1049
kodiakhq[bot] 6c6c386
Merge branch 'main' into iss-1049
kodiakhq[bot] 49717c7
docs: resolve formatting issue in page-issue-link
bertday 691905c
Merge branch 'main' into iss-1049
kodiakhq[bot] 4333236
Merge branch 'main' into iss-1049
kodiakhq[bot] 793707c
Merge branch 'main' into iss-1049
kodiakhq[bot] 0335938
Merge branch 'main' into iss-1049
kodiakhq[bot] 38925ae
Merge branch 'main' into iss-1049
kodiakhq[bot] 7a8de23
docs: use backticks in page-issue-link
bertday bf27057
Update src/ui/page-issue-link.tsx
bertday 5e6e2c6
Merge branch 'main' into iss-1049
kodiakhq[bot] daa1ce1
Merge branch 'main' into iss-1049
kodiakhq[bot] a42d7b4
Merge branch 'main' into iss-1049
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
feat: Auto-populate page field when reporting an issue
Also makes the GitHub URL multiline for readabillity. Closes #1049
commit bf08606d68a548d2118e1e034cd0475cfcecb4b4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bertday A formatting issue is blocking this PR. Could you please format the file or use the following code:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amirhhashemi , this should be resolved now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bertday My bad, I should've used ` instead of " for strings. I didn't notice template strings are required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amirhhashemi , just pushed a change to bring this backticks back. Really hoping this does this trick.