Add info about error casting in in createResource #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amirhhashemi
commented
Feb 16, 2025
Comment on lines
+37
to
+41
| <Callout title="Note"> | ||
|
|
||
| If you anticipate errors, you may want to wrap `createResource` in an [ErrorBoundary](/reference/components/error-boundary). | ||
|
|
||
| </Callout> |
There was a problem hiding this comment.
This is out of place but I couldn't find a better place for it. It shouldn't be here in the first place. Maybe we should mention it somewhere here instead.
There was a problem hiding this comment.
I agree - probably best to add under Using createResource
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LadyBluenotes
requested changes
Feb 18, 2025
|
|
||
| As of **v1.4.0**, `data.latest` will return the last returned value and won't trigger [Suspense](/reference/components/suspense) and [transitions](#TODO); if no value has been returned yet, `data.latest` acts the same as `data()`. | ||
| This can be useful if you want to show the out-of-date data while the new data is loading. | ||
| - `data.loading` tells you if the fetcher has been called but not returned. |
There was a problem hiding this comment.
Suggested change
| - `data.loading` tells you if the fetcher has been called but not returned. | |
| - `data.loading`: whether the fetcher has been called but not returned. |
| As of **v1.4.0**, `data.latest` will return the last returned value and won't trigger [Suspense](/reference/components/suspense) and [transitions](#TODO); if no value has been returned yet, `data.latest` acts the same as `data()`. | ||
| This can be useful if you want to show the out-of-date data while the new data is loading. | ||
| - `data.loading` tells you if the fetcher has been called but not returned. | ||
| - `data.error` tells you if the request has errored out. |
There was a problem hiding this comment.
Suggested change
| - `data.error` tells you if the request has errored out. | |
| - `data.error`: if the request has errored out. |
| This can be useful if you want to show the out-of-date data while the new data is loading. | ||
| - `data.loading` tells you if the fetcher has been called but not returned. | ||
| - `data.error` tells you if the request has errored out. | ||
| `createResource` always provides an `Error` object for `data.error`, even if the fetcher throws something else. |
There was a problem hiding this comment.
Suggested change
| `createResource` always provides an `Error` object for `data.error`, even if the fetcher throws something else. | |
| `createResource`: provides an `Error` object for `data.error`. It will show even if the fetcher throws something else. |
Comment on lines
+33
to
+35
| - If the fetcher throws an `Error` instance, `data.error` will be that instance. | ||
| - If the fetcher throws a string, `data.error.message` will contain that string. | ||
| - If the fetcher throws a value that is neither an `Error` nor a string, that value will be available as `data.error.cause`. |
There was a problem hiding this comment.
Suggested change
| - If the fetcher throws an `Error` instance, `data.error` will be that instance. | |
| - If the fetcher throws a string, `data.error.message` will contain that string. | |
| - If the fetcher throws a value that is neither an `Error` nor a string, that value will be available as `data.error.cause`. | |
| - Fetcher throws an `Error` instance, `data.error` will be that instance. | |
| - If the fetcher throws a string, `data.error.message` will contain that string. | |
| - When the fetcher throws a value that is neither an `Error` nor a string, that value will be available as `data.error.cause`. |
Comment on lines
+37
to
+41
| <Callout title="Note"> | ||
|
|
||
| If you anticipate errors, you may want to wrap `createResource` in an [ErrorBoundary](/reference/components/error-boundary). | ||
|
|
||
| </Callout> |
There was a problem hiding this comment.
I agree - probably best to add under Using createResource
|
|
||
| </Callout> | ||
|
|
||
| - As of **v1.4.0**, `data.latest` will return the last returned value and won't trigger [Suspense](/reference/components/suspense) and [transitions](#TODO); if no value has been returned yet, `data.latest` acts the same as `data()`. |
There was a problem hiding this comment.
Suggested change
| - As of **v1.4.0**, `data.latest` will return the last returned value and won't trigger [Suspense](/reference/components/suspense) and [transitions](#TODO); if no value has been returned yet, `data.latest` acts the same as `data()`. | |
| - As of **v1.4.0**, `data.latest` returns the last value received and will not trigger [Suspense](/reference/components/suspense) or [transitions](#TODO); if no value has been returned yet, `data.latest` will act the same as `data()`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description(required)
This PR adds more information about how
createResourcecasts errors.Related issues & labels
castErrorbehavior ofcreateResourceshould be documented #825