-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update formating, linting, and some dependencies #1117
Conversation
|
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think running Prettier is needed. Lots of files have formatting issues.
4990cac
to
36e942d
Compare
@LadyBluenotes It seems you have started from scratch, which is fine. However, many of the issues I addressed in the previous PR will need to be redone. This will require quite a bit of work. Specifically, this commit illustrates the amount of work that lies ahead. I recommend continuing with that pull request, but if you feel more comfortable handling it yourself, that's perfectly fine with me. |
Co-authored-by: Amir Hossein Hashemi <[email protected]>
I have run prettier - i think there may be some settings that aren't properly working, as far as i can see. I know there's a bit to do still |
Maybe we should get this merged to fix Netlify builds and address more prettier changes in a different PR? |
This reverts commit 0fd3e48.
Description(required)
Upgrades outdated dependencies, fixes broken checks, adds formatting check
Credit to @amirhhashemi in #1001 for setting creating most of the checks
Related issues & labels
pnpm dev
doesn't work on Windows #1111 [Other]: Unformatted files #1000