Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update formating, linting, and some dependencies #1117

Merged
merged 9 commits into from
Mar 10, 2025
Merged

Conversation

LadyBluenotes
Copy link
Member

@LadyBluenotes LadyBluenotes commented Mar 9, 2025

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

Upgrades outdated dependencies, fixes broken checks, adds formatting check

Credit to @amirhhashemi in #1001 for setting creating most of the checks

Related issues & labels

Copy link

stackblitz bot commented Mar 9, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for solid-docs failed. Why did it fail? →

Name Link
🔨 Latest commit ea9d1f4
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67ce580d185d120008e39199

Copy link
Collaborator

@amirhhashemi amirhhashemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think running Prettier is needed. Lots of files have formatting issues.

@amirhhashemi
Copy link
Collaborator

amirhhashemi commented Mar 9, 2025

@LadyBluenotes It seems you have started from scratch, which is fine. However, many of the issues I addressed in the previous PR will need to be redone. This will require quite a bit of work. Specifically, this commit illustrates the amount of work that lies ahead.

I recommend continuing with that pull request, but if you feel more comfortable handling it yourself, that's perfectly fine with me.

Co-authored-by: Amir Hossein Hashemi <[email protected]>
@LadyBluenotes
Copy link
Member Author

@LadyBluenotes It seems you have started from scratch, which is fine. However, many of the issues I addressed in the previous PR will need to be redone. This will require quite a bit of work. Specifically, this commit illustrates the amount of work that lies ahead.

I recommend continuing with that pull request, but if you feel more comfortable handling it yourself, that's perfectly fine with me.

I have run prettier - i think there may be some settings that aren't properly working, as far as i can see. I know there's a bit to do still

@jer3m01
Copy link
Member

jer3m01 commented Mar 9, 2025

Maybe we should get this merged to fix Netlify builds and address more prettier changes in a different PR?

@LadyBluenotes LadyBluenotes merged commit 0fd3e48 into main Mar 10, 2025
1 of 3 checks passed
@LadyBluenotes LadyBluenotes deleted the deps-format-lint branch March 10, 2025 03:10
LadyBluenotes added a commit that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: pnpm dev doesn't work on Windows
3 participants