Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some grammar and typo issues #941

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Fix some grammar and typo issues #941

wants to merge 8 commits into from

Conversation

Hasan-Mir
Copy link

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

This PR fixes some grammar and typo issues.

Related issues & labels

  • Closes #
  • Suggested label(s) (optional):

@stackblitz StackBlitz
Copy link

stackblitz bot commented Nov 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify Netlify
Copy link

netlify bot commented Nov 1, 2024 •
edited
Loading

✅ Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit ef3c1f5
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6728d1c57324a400088b99be
😎 Deploy Preview https://deploy-preview-941--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

LadyBluenotes
LadyBluenotes requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@LadyBluenotes LadyBluenotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding some ways to make sentences flow a bit better! Just a few of the changes don't quite work, but once they're addressed we can merge this in

src/routes/concepts/control-flow/portal.mdx Outdated Show resolved Hide resolved
src/routes/concepts/stores.mdx Outdated Show resolved Hide resolved
@Hasan-Mir Hasan-Mir marked this pull request as draft November 4, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadyBluenotes LadyBluenotes LadyBluenotes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hasan-Mir @LadyBluenotes