fix #1982 ErrorBoundary with ExternalSource

solidjs · Jan 3, 2024 · 292aba4 · 292aba4
1 parent 968e2cc
commit 292aba4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/moody-spiders-do.md b/.changeset/moody-spiders-do.md
@@ -0,0 +1,5 @@
+---
+"solid-js": patch
+---
+
+fix #1982 ErrorBoundary with ExternalSource
diff --git a/packages/solid/src/reactive/signal.ts b/packages/solid/src/reactive/signal.ts
@@ -1428,7 +1428,7 @@ function createComputation<Next, Init = unknown>(
 
   if ("_SOLID_DEV_" && options && options.name) c.name = options.name;
 
-  if (ExternalSourceFactory) {
+  if (ExternalSourceFactory && c.fn) {
     const [track, trigger] = createSignal<void>(undefined, { equals: false });
     const ordinary = ExternalSourceFactory(c.fn, trigger);
     onCleanup(() => ordinary.dispose());