add more tests

solidjs · Oct 1, 2024 · 64fd974 · 64fd974
1 parent ab424d5
commit 64fd974
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/solid/src/reactive/signal.ts b/packages/solid/src/reactive/signal.ts
@@ -179,12 +179,12 @@ export function createRoot<T>(fn: RootFunction<T>, detachedOwner?: typeof Owner)
 export type Accessor<T> = () => T;
 
 export type Setter<in out T> = {
+  <U extends T>(value: Exclude<U, Function> | ((prev: T) => U)): U;
   <U extends T>(
     ...args: undefined extends T ? [] : [value: Exclude<U, Function> | ((prev: T) => U)]
   ): undefined extends T ? undefined : U;
   <U extends T>(value: (prev: T) => U): U;
   <U extends T>(value: Exclude<U, Function>): U;
-  <U extends T>(value: Exclude<U, Function> | ((prev: T) => U)): U;
 };
 
 export type Signal<T> = [get: Accessor<T>, set: Setter<T>];

diff --git a/packages/solid/test/signals.type-tests.ts b/packages/solid/test/signals.type-tests.ts
@@ -887,11 +887,13 @@ interface KobalteBaseSelectProps<Option, OptGroup = never> {
 interface KobaltSingleSelectProps<T> {
   value?: T | null;
   onChange?: (value: T) => void;
+  multiple?: false;
 }
 
 interface KobaltMultiSelectProps<T> {
   value?: T[];
   onChange?: (value: T[]) => void;
+  multiple?: true;
 }
 
 type KobaltSelectProps<Option, OptGroup = never> = (
@@ -903,8 +905,15 @@ type KobaltSelectProps<Option, OptGroup = never> = (
 type fruits = "apple" | "banana" | "orange";
 const fruits: fruits[] = ["apple", "banana", "orange"];
 const [fruit, setFruit] = createSignal<fruits>("apple");
+const [fruitArr, setFruitArr] = createSignal<fruits[]>(["apple"]);
 function kobalteSelect<T>(props: KobaltSelectProps<T>) {}
 kobalteSelect({ value: fruit(), onChange: setFruit, options: fruits });
+kobalteSelect<fruits>({
+  value: fruitArr(),
+  onChange: setFruitArr,
+  options: fruits,
+  multiple: true
+});
 
 //////////////////////////////////////////////////////////////////////////
 // test explicit generic args ////////////////////////////////////////////