fix #1973 array over object reconcile

solidjs · Jan 3, 2024 · b887587 · b887587
1 parent 40b5d78
commit b887587
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/weak-wombats-invite.md b/.changeset/weak-wombats-invite.md
@@ -0,0 +1,5 @@
+---
+"solid-js": patch
+---
+
+fix #1973 array over object reconcile
diff --git a/packages/solid/store/src/modifiers.ts b/packages/solid/store/src/modifiers.ts
@@ -16,15 +16,19 @@ function applyState(
 ) {
   const previous = parent[property];
   if (target === previous) return;
+  const isArray = Array.isArray(target);
   if (
     property !== $ROOT &&
-    (!isWrappable(target) || !isWrappable(previous) || (key && target[key] !== previous[key]))
+    (!isWrappable(target) ||
+      !isWrappable(previous) ||
+      (isArray && !Array.isArray(previous)) ||
+      (key && target[key] !== previous[key]))
   ) {
     setProperty(parent, property, target);
     return;
   }
 
-  if (Array.isArray(target)) {
+  if (isArray) {
     if (
       target.length &&
       previous.length &&