fix types of defer for on

solidjs · Sep 16, 2023 · f694830 · f694830
1 parent f84f356
commit f694830
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/packages/solid/src/reactive/signal.ts b/packages/solid/src/reactive/signal.ts
@@ -917,7 +917,7 @@ export function on<S, Next extends Prev, Prev = Next>(
 export function on<S, Next extends Prev, Prev = Next>(
   deps: AccessorArray<S> | Accessor<S>,
   fn: OnEffectFunction<S, undefined | NoInfer<Prev>, Next>,
-  options: OnOptions & { defer: true }
+  options: OnOptions | { defer: true }
 ): EffectFunction<undefined | NoInfer<Next>>;
 export function on<S, Next extends Prev, Prev = Next>(
   deps: AccessorArray<S> | Accessor<S>,

diff --git a/packages/solid/test/signals.type-tests.ts b/packages/solid/test/signals.type-tests.ts
@@ -710,6 +710,25 @@ const onMemo3 = createMemo(
 );
 // @ts-expect-error when deferred the type includes undefined
 const onMemo4: Accessor<number> = onMemo3;
+// Allow passing boolean to defer
+const memoCreator = (defer: boolean) =>
+  createMemo(
+    on(
+      [one, two],
+      (input, prevInput, prev) => {
+        const [one, two]: [number, boolean] = input;
+        if (prevInput) {
+          const [prevOne, prevTwo]: [number, boolean] = prevInput;
+        }
+        // @ts-expect-error FIXME computed type is unknown, should be `number`.
+        const _prev: number = prev;
+        return one + +two;
+      },
+      { defer }
+    )
+  );
+const memoCreator1: Accessor<number | undefined> = memoCreator(true);
+const memoCreator2: Accessor<number | undefined> = memoCreator(false);
 
 //////////////////////////////////////////////////////////////////////////
 // createSelector ////////////////////////////////////////////////////////