Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate vitest browser isntance #178

Merged

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Jan 31, 2025

Inspired by the patch here:

simonihmig/responsive-image#963 (comment)

Fixes this error:

Error: Cannot define a nested project for a chromium browser. The project name "chromium" was already defined. If you have multiple instances for the same browser, make sure to define a custom "name". All projects in a workspace should have unique names. Make sure your configuration is correct.

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: fcfc3bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jan 31, 2025

Open in Stackblitz

npm i https://pkg.pr.new/vite-plugin-solid@178

commit: fcfc3bf

@birkskyum birkskyum merged commit e2891d1 into solidjs:main Jan 31, 2025
2 checks passed
@birkskyum
Copy link
Member Author

birkskyum commented Jan 31, 2025

Hit the merge button by mistake here (!) - let's add a min. 1 review branch protection to avoid such things.

birkskyum added a commit that referenced this pull request Jan 31, 2025
birkskyum added a commit that referenced this pull request Jan 31, 2025
* Revert "Fix duplicate vitest browser isntance (#178)"

This reverts commit e2891d1.

* remove changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant