-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update solidus4 compatibility #92
Update solidus4 compatibility #92
Conversation
Hi @shahmayur001 here You can find my PR, where I added the latest 2 commits and everything should be fine now. If you like my changes please cherry-pick them to your PR so we can go ahead with the review! Thank you for your work 💪 |
@DanielePalombo Thanks for your help! 🙌 I’ve already cherry-picked your commits. Appreciate your help! 💪 |
Hi @kennyadsl, Do you think we can line up this PR for review? Let me know your thoughts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested locally. Everything seems fine to me
Thanks @shahmayur001 and @DanielePalombo ! |
Summary
This pull request includes several changes related to the integration of virtual gift cards within the Spree admin interface and other parts of the application. It also resolves compatibility issues with Solidus version updates. Key updates include moving overrides and updating routing and initializer configurations.
Changes
Gift Cards Controller
redirect_to :back
toredirect_back(fallback_location: admin_orders_path)
in thesend_email
action of theGiftCardsController
to avoid potential deprecation issues.Deface Overrides
SolidusVirtualGiftCard
module.Menu Configuration
Order Decorator
finalize
method on the decorator to update the gift card and make it redeemable.Gift Cards Lookup Form
RuboCop Configuration Updates
Layout/AlignArguments
toLayout/ArgumentAlignment
in.rubocop_todo.yml
.Metrics/LineLength
toLayout/LineLength
.New Configuration Setting
send_gift_card_emails
setting in theSolidusVirtualGiftCard
configuration to enable or disable sending gift card email notifications.Sponsorship