Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solidus4 compatibility #92

Merged

Conversation

shahmayur001
Copy link
Contributor

@shahmayur001 shahmayur001 commented Dec 6, 2024

Summary

This pull request includes several changes related to the integration of virtual gift cards within the Spree admin interface and other parts of the application. It also resolves compatibility issues with Solidus version updates. Key updates include moving overrides and updating routing and initializer configurations.

Changes

Gift Cards Controller

  • Updated redirect_to :back to redirect_back(fallback_location: admin_orders_path) in the send_email action of the GiftCardsController to avoid potential deprecation issues.

Deface Overrides

  • Removed outdated and redundant Deface overrides.
  • Added new Deface overrides for integrating gift card information in order and user views under the SolidusVirtualGiftCard module.

Menu Configuration

  • Added an initializer to include Gift Cards in the admin menu under the Users section.
  • Conditionally displayed the menu item based on user permissions.

Order Decorator

  • Used the finalize method on the decorator to update the gift card and make it redeemable.

Gift Cards Lookup Form

  • Changed the field to search with the order number.

RuboCop Configuration Updates

  • Renamed Layout/AlignArguments to Layout/ArgumentAlignment in .rubocop_todo.yml.
  • Updated Metrics/LineLength to Layout/LineLength.

New Configuration Setting

  • Introduced the send_gift_card_emails setting in the SolidusVirtualGiftCard configuration to enable or disable sending gift card email notifications.

Sponsorship

  • 🙏 This work was sponsored by Triodec Solutions, who provided valuable contributions and support for the development of this feature.

@DanielePalombo
Copy link
Collaborator

Hi @shahmayur001
I was impressed by your PR and I decided to contribute.

here You can find my PR, where I added the latest 2 commits and everything should be fine now. If you like my changes please cherry-pick them to your PR so we can go ahead with the review!

Thank you for your work 💪

@shahmayur001
Copy link
Contributor Author

Hi @shahmayur001 I was impressed by your PR and I decided to contribute.

here You can find my PR, where I added the latest 2 commits and everything should be fine now. If you like my changes please cherry-pick them to your PR so we can go ahead with the review!

Thank you for your work 💪

@DanielePalombo Thanks for your help! 🙌 I’ve already cherry-picked your commits. Appreciate your help! 💪

@shahmayur001 shahmayur001 marked this pull request as ready for review January 11, 2025 20:58
@shahmayur001
Copy link
Contributor Author

Hi @kennyadsl,

Do you think we can line up this PR for review?

Let me know your thoughts!

Copy link
Collaborator

@DanielePalombo DanielePalombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally. Everything seems fine to me

@kennyadsl kennyadsl merged commit 6e83934 into solidusio-contrib:master Jan 13, 2025
6 checks passed
@kennyadsl
Copy link
Member

Thanks @shahmayur001 and @DanielePalombo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants