Remove rails binstub from built gems

The bin/rails script is solely used for local dev purposes. Since the default bindir from Rubygems is bin the binstub gets installed with the gems. This can cause issues with the rails command comming from rails itself. Also removing the old script/rails files, which were excluded to solve the same issue.
solidusio · Nov 14, 2024 · dde8966 · dde8966
1 parent b1a3796
commit dde8966
Show file tree

Hide file tree

Showing 9 changed files with 7 additions and 37 deletions.
diff --git a/admin/solidus_admin.gemspec b/admin/solidus_admin.gemspec
@@ -22,7 +22,7 @@ Gem::Specification.new do |s|
   s.metadata["changelog_uri"] = "https://github.com/solidusio/solidus/releases?q=%22solidus_admin%2Fv0%22&expanded=true"
 
   s.files = `git ls-files -z`.split("\x0").reject do |f|
-    f.match(%r{^(spec|script)/})
+    f.match(%r{^(spec|bin)/})
   end + ["app/assets/builds/solidus_admin/tailwind.css"]
 
   s.required_ruby_version = '>= 3.1.0'

diff --git a/api/script/rails b/api/script/rails
diff --git a/api/solidus_api.gemspec b/api/solidus_api.gemspec
@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
   s.metadata['rubygems_mfa_required'] = 'true'
 
   s.files = `git ls-files -z`.split("\x0").reject do |f|
-    f.match(%r{^(spec|script)/})
+    f.match(%r{^(spec|bin)/})
   end
 
   s.required_ruby_version = '>= 3.1.0'

diff --git a/backend/script/rails b/backend/script/rails
diff --git a/backend/solidus_backend.gemspec b/backend/solidus_backend.gemspec
@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
   s.metadata['rubygems_mfa_required'] = 'true'
 
   s.files = `git ls-files -z`.split("\x0").reject do |f|
-    f.match(%r{^(spec|script)/})
+    f.match(%r{^(spec|bin)/})
   end
 
   s.required_ruby_version = '>= 3.1.0'

diff --git a/core/script/rails b/core/script/rails
diff --git a/core/solidus_core.gemspec b/core/solidus_core.gemspec
@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
   s.metadata['rubygems_mfa_required'] = 'true'
 
   s.files = `git ls-files -z`.split("\x0").reject do |f|
-    f.match(%r{^(spec|script)/})
+    f.match(%r{^(spec|bin)/})
   end
 
   s.required_ruby_version = '>= 3.1.0'

diff --git a/legacy_promotions/solidus_legacy_promotions.gemspec b/legacy_promotions/solidus_legacy_promotions.gemspec
@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
   s.metadata['rubygems_mfa_required'] = 'true'
 
   s.files = `git ls-files -z`.split("\x0").reject do |f|
-    f.match(%r{^(spec|script)/})
+    f.match(%r{^(spec|bin)/})
   end
 
   s.required_ruby_version = '>= 3.1.0'

diff --git a/promotions/solidus_promotions.gemspec b/promotions/solidus_promotions.gemspec
@@ -17,12 +17,12 @@ Gem::Specification.new do |spec|
 
   spec.metadata["homepage_uri"] = spec.homepage
 
-  spec.required_ruby_version = ">= 3.0.0"
+  spec.required_ruby_version = ">= 3.1.0"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   files = Dir.chdir(__dir__) { `git ls-files -z`.split("\x0") }
-  spec.files = files.grep_v(%r{^(test|spec|features)/})
+  spec.files = files.grep_v(%r{^(spec|bin)/})
 
   spec.add_dependency "importmap-rails", "~> 1.2"
   spec.add_dependency "ransack-enum", "~> 1.0"