Deprecate the use of MenuItem#position

Rely on the implicit array ordering.
solidusio · Sep 21, 2023 · f6e8e70 · f6e8e70
1 parent 6fb2c79
commit f6e8e70
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/backend/app/views/spree/admin/shared/_tabs.html.erb b/backend/app/views/spree/admin/shared/_tabs.html.erb
@@ -1,4 +1,4 @@
-<% Spree::Backend::Config.menu_items.sort_by { |item| item.position || Float::INFINITY }.each do |menu_item| %>
+<% Spree::Backend::Config.menu_items.each do |menu_item| %>
   <% if menu_item.render_in?(self) %>
     <%=
       tab(

diff --git a/backend/lib/spree/backend_configuration/menu_item.rb b/backend/lib/spree/backend_configuration/menu_item.rb
@@ -11,7 +11,9 @@ def sections # rubocop:disable Style/TrivialAccessors
       end
       deprecate sections: :label, deprecator: Spree::Deprecation
 
-      attr_accessor :position
+      attr_accessor :position # rubocop:disable Layout/EmptyLinesAroundAttributeAccessor
+      deprecate position: nil, deprecator: Spree::Deprecation
+      deprecate "position=": nil, deprecator: Spree::Deprecation
 
       # @param icon [String] The icon to draw for this menu item
       # @param condition [Proc] A proc which returns true if this menu item