Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Move product index title logic to the component class #5308

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[Admin] Move product index title logic to the component class #5308

merged 1 commit into from
Aug 7, 2023

Conversation

waiting-for-dev
Copy link
Contributor

Summary

This change was lost while reworking #5176.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev requested a review from a team as a code owner August 7, 2023 09:52
@waiting-for-dev waiting-for-dev self-assigned this Aug 7, 2023
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Aug 7, 2023
@waiting-for-dev waiting-for-dev merged commit a153e27 into solidusio:nebulab/admin Aug 7, 2023
3 checks passed
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/admin/products_title branch August 7, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

@elia elia elia approved these changes

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_admin type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waiting-for-dev @elia @rainerdema