Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Focus on the search field when rendered #5317

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[Admin] Focus on the search field when rendered #5317

merged 1 commit into from
Aug 9, 2023

Conversation

waiting-for-dev
Copy link
Contributor

Summary

When the filter button is clicked, focus on the search field so that the user can start typing right away.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev requested a review from a team as a code owner August 9, 2023 06:37
@waiting-for-dev waiting-for-dev self-assigned this Aug 9, 2023
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Aug 9, 2023
@waiting-for-dev
Copy link
Contributor Author

CI will be fixed once we rebase with #5318

elia
elia approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

I guess the linting error is related to #5318

@waiting-for-dev
Focus on the search field when rendered
c182246 
When the filter button is clicked, focus on the search field so that
the user can start typing right away.
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/admin/filter_focus branch from 1ed7ac4 to c182246 Compare August 9, 2023 08:47
@waiting-for-dev waiting-for-dev merged commit baf2dfc into solidusio:nebulab/admin Aug 9, 2023
2 checks passed
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/admin/filter_focus branch August 9, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

@the-krg the-krg Awaiting requested review from the-krg

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_admin type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waiting-for-dev @elia