Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Tweaks for search area a11y #5321

Merged
merged 3 commits into from
Aug 11, 2023
Merged

[Admin] Tweaks for search area a11y #5321

merged 3 commits into from
Aug 11, 2023

Conversation

waiting-for-dev
Copy link
Contributor

Summary

  • Give role search to all the search and filters area
  • Use "search" type for the search field in the admin UI
  • Use native aria-label instead of hidden text for labels within search

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev
Give role search to all the search and filters area
56c66c9 
Giving a landmark to the search and filters area will help screen
readers to navigate to it.
@waiting-for-dev waiting-for-dev requested a review from a team as a code owner August 9, 2023 13:12
@waiting-for-dev waiting-for-dev self-assigned this Aug 9, 2023
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Aug 9, 2023
@waiting-for-dev
Use "search" type for the search field in the admin UI
b0df442 
That will automatically convey the searchbox role to assistive
technologies.

We need to remove the cancel button "pseudo-element" on webkit. For
that, we add a new Tailwind variant.
@waiting-for-dev
Use native aria-label instead of hidden text for labels within search
a9f35c3
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/admin/search_role branch from 5268dbe to a9f35c3 Compare August 10, 2023 04:22
@waiting-for-dev waiting-for-dev merged commit df03854 into solidusio:nebulab/admin Aug 11, 2023
2 checks passed
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/admin/search_role branch August 11, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-krg the-krg the-krg approved these changes

@elia elia elia approved these changes

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_admin type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waiting-for-dev @elia @the-krg