Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Add a label to the batch actions form to make it a landmark #5323

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[Admin] Add a label to the batch actions form to make it a landmark #5323

merged 1 commit into from
Aug 10, 2023

Conversation

waiting-for-dev
Copy link
Contributor

Summary

For a form to be a landmark and be announced by screen readers, it needs to have an associated accessible name. See
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/form_role:

Using the

element will automatically communicate a section of content as a form landmark, if it is provided an accessible name.

Closes #5274

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev requested a review from a team as a code owner August 9, 2023 13:39
@waiting-for-dev waiting-for-dev self-assigned this Aug 9, 2023
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Aug 9, 2023
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/admin/batch_actions_a11y branch from 9eeb58e to 3ac6f69 Compare August 10, 2023 04:27
@waiting-for-dev
Add a label to the batch actions section to make it a landmark
aeb6f42 
For a form to be a landmark and be announced by screen readers, it needs
to have an associated accessible name [1].

> Using the <form> element will automatically communicate a section of
> content as a form landmark, if it is provided an accessible name.

[1] - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/form_role

Closes solidusio#5274
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/admin/batch_actions_a11y branch from 3ac6f69 to aeb6f42 Compare August 10, 2023 04:27
@waiting-for-dev waiting-for-dev merged commit 6883d21 into solidusio:nebulab/admin Aug 10, 2023
2 checks passed
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/admin/batch_actions_a11y branch August 10, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_admin type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waiting-for-dev @elia