Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.0] Bump the minimum required Psych version #5326

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from main to v4.0:

Questions ?

Please refer to the Backport tool documentation

The existing code already breaks with older versions and this just
reflects the minimum version that works in the gemspec.

Psych v4.0.1 is the one introducing `YAML.safe_dump` which we're using
to store LogEntry serialized details.

Fixes #5320.

(cherry picked from commit 7d150db)
@github-actions github-actions bot requested a review from a team as a code owner August 10, 2023 03:22
@waiting-for-dev waiting-for-dev changed the title [v4.0] Merge pull request #5322 from solidusio/elia/psych-version [v4.0] Bump the minimum required Psych version Aug 10, 2023
@waiting-for-dev waiting-for-dev added the changelog:solidus_core Changes to the solidus_core gem label Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #5326 (2329f2f) into v4.0 (e34b131) will increase coverage by 16.53%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             v4.0    #5326       +/-   ##
===========================================
+ Coverage   72.01%   88.54%   +16.53%     
===========================================
  Files         563      563               
  Lines       14825    13889      -936     
===========================================
+ Hits        10676    12298     +1622     
+ Misses       4149     1591     -2558     

see 63 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@waiting-for-dev waiting-for-dev merged commit f13e438 into v4.0 Aug 10, 2023
4 checks passed
@waiting-for-dev waiting-for-dev deleted the backport/v4.0/pr-5322 branch August 10, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants