[Admin] Add orders/index component with order list table
#5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerdema
changed the title
orders/index component with order list tableorders/index component with order list table
rainerdema
force-pushed
the
admin/rainerd/orders-list
branch
from
628ea04
to
9faded0
Compare
4 tasks
admin/app/components/solidus_admin/orders/index/component.html.erb
Outdated
Show resolved
Hide resolved
rainerdema
force-pushed
the
admin/rainerd/orders-list
branch
from
9faded0
to
daa5758
Compare
rainerdema
force-pushed
the
admin/rainerd/orders-list
branch
from
daa5758
to
cd41eca
Compare
This new component includes an order list that is similar to the existing order list but features different columns to represent orders.
Changes include: - Addition of new filter in `filters` method in the orders index component, now includes an additional filter for 'only_show_complete_orders'. Please note that this is a special case of filters in the context of transitioning from the old to the new orders index page. This change ensures that the feature set between the old and new orders index page remains consistent until we introduce the new filter component.
rainerdema
force-pushed
the
admin/rainerd/orders-list
branch
from
cd41eca
to
57bd09c
Compare
rainerdema
force-pushed
the
admin/rainerd/orders-list
branch
from
ce806b7
to
37cad8e
Compare
waiting-for-dev
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Cool, @rainerdema! Left a couple of non-blocking comments. Leaving to you the call about the feedback component.
Extracted the feedback button into its own component for reuse across multiple pages. This reduces duplication, and allows for easier maintenance in case we want to update or modify the feedback button in the future. ``` bin/rails generate solidus_admin:component feedback button_component ```
- Introduced a 'fade_row_proc' parameter to the table component to determine if rows should be faded or not based on a condition. - Updated YARD documentation for the `SolidusAdmin::UI::Table::Component` class to include the new attribute.
rainerdema
force-pushed
the
admin/rainerd/orders-list
branch
from
37cad8e
to
c88ce36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new
orders/indexcomponent that is structured similarly to the existingproducts/indexcomponent.Only show complete ordersfilterAdmin.Add.orders.index.component.with.order.list.table_2.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: