[Admin] Add text_field component #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waiting-for-dev
force-pushed
the
waiting-for-dev/admin/text_field_component
branch
from
f48e2b6
to
d580785
Compare
tvdeyen
reviewed
Aug 17, 2023
admin/app/components/solidus_admin/ui/forms/text_field/component.rb
Outdated
Show resolved
Hide resolved
waiting-for-dev
force-pushed
the
waiting-for-dev/admin/text_field_component
branch
from
d580785
to
34a7a52
Compare
rainerdema
approved these changes
Aug 17, 2023
This component is used to render a text field in a form. It leverages the `type` attribute to also render different input fields, although we might want to specialize in the future. It comes in three sizes: small, medium and large. It also supports rendering a label and a hint, as well as field error messages. It needs to be rendered in the context of a block yielded by one of Rails' form helpers, such as `form_for` or `form_with`. This is to leverage the automatic inferrence of the `name`, `id` and `for` attributes, therefore avoiding boilerplate. When the given form builder is bound to a model instance, the error messages will be automatically extracted. Otherwise, an explicit errors hash needs to be passed. Ref. solidusio#5329
waiting-for-dev
force-pushed
the
waiting-for-dev/admin/text_field_component
branch
from
34a7a52
to
7ef640d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This component is used to render a text field in a form. It leverages the
typeattribute to also render different input fields, although we might want to specialize in the future.It comes in three sizes: small, medium and large. It also supports rendering a label and a hint, as well as field error messages.
It needs to be rendered in the context of a block yielded by one of Rails' form helpers, such as
form_fororform_with. This is to leverage the automatic inferrence of thename,idandforattributes, therefore avoiding boilerplate. When the given form builder is bound to a model instance, the error messages will be automatically extracted. Otherwise, an explicit errors hash needs to be passed.Ref. #5329
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: