Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor sandbox generation issues #5618

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fix minor sandbox generation issues #5618

merged 2 commits into from
Jan 24, 2024

Commits on Jan 24, 2024

  1. Append to .gitignore only when file exists 

    This prevent the following error when the `.gitignore` file is
not present, for example when creating sandbox app:

  Rails::Generators::Error: The template [/path/to/solidus/admin/lib/solidus_admin/install_tailwindcss.rb] could not be loaded.
  Error: The file /path/to/solidus/sandbox/.gitignore does not appear to exist (Rails::Generators::Error)

  Caused by:
  Thor::Error: The file /path/to/solidus/sandbox/.gitignore does not appear to exist (Thor::Error)
    @spaghetticode
    spaghetticode committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b4f14e8 View commit details
    Browse the repository at this point in the history

  2. Run bundle add solidus_admin only when missing 

    This avoids errors when running the installer on apps that already
include that gem, for example when creating the sandbox.
    @spaghetticode
    spaghetticode committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    17647e5 View commit details
    Browse the repository at this point in the history