Add Admin Tailwind build when generating sandbox #5636
Conversation
github-actions
bot
added
changelog:solidus_core
|
Thanks @spaghetticode. I don't understand why the build file is not present locally only, or if you use the GH version of Solidus, while it's present if you use the RubyGems version. Can you help me? |
|
@kennyadsl that's because by design we've decided to avoid committing the CSS build file, so it's absent from GH/local copies of the repo. |
|
Ah, you are right, got it. What do you think about building this file during the installation the default option?
What you did works, but I would hide this technical detail to new users. |
spaghetticode
force-pushed
the
spaghetticode/admin-tailwind-sandbox-fix
branch
from
52e6e5d
to
5461604
Compare
github-actions
bot
removed
the
changelog:repository
|
@kennyadsl thanks for your comment, I updated the PR description and the code and now the flag is set to |
This facilitates editing sandbox routes and Procfile when installing Tailwind.
This way, we can provide the option to (not) build the Tailwind CSS file and add rake tasks for managing Admin Tailwind assets. The flag is added to the Solidus installer, then passed along when installing the new admin.
The preferred (AKA the only way that fully works) way to start the sanbox is via `bin/dev`. Same thing when installing Solidus from Github or the local filesystem.
spaghetticode
force-pushed
the
spaghetticode/admin-tailwind-sandbox-fix
branch
from
5461604
to
26ed5f7
Compare
| apply_template_for :authentication, @selected_authentication | ||
| apply_template_for :frontend, @selected_frontend | ||
| apply_template_for :payment_method, @selected_payment_method | ||
| generate "solidus_admin:install #{'--tailwind' if options[:build_admin_tailwind]}" |
There was a problem hiding this comment.
Sorry for the back and forth (and it might not be related to this PR), but at this point I don't understand in which case we don't need to install Tailwind along with the new admin. I mean, in which circumstances build_admin_tailwind will be set to false?
There was a problem hiding this comment.
Right now, never. But if for any reason somebody wants to disable it, we give the possibility to do it with rails g solidus:install --no-build-admin-tailwind, for example.
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
spaghetticode
added
backport-v4.3
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Summary
Fixes #5598
This PR attempts to fix the error
couldn't find file 'solidus_admin/tailwind.css'when loading admin pages from the sandbox application.The error is caused by the absence of the Admin Tailwind CSS build file, which doesn't exist on (local) copies of the project codebase from GitHub.
The fix adds the new flag
--build-admin-tailwindto theinstallprocess that controls whether to build the CSS file and install the associated rake tasks into the sandbox application. The flag defaults totrue, so installing Solidus will build Admin Tailwind CSS and add rake tasks. This can be disabled withrails g solidus:install --no-build-admin-tailwind, seerails g solidus:install --helpfor more context.The only effective way to run the server is now via
bin/dev.Also, the main
READMEis updated with the new relevant information.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
(https://github.com/solidusio/.github/blob/main/CONTRIBUTING.md#writing-good-commit-messages).
The following are not always needed: