-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] adding new shipping category #5718
[Admin] adding new shipping category #5718
Conversation
Thanks @loicginoux! I created #5720 to attach to this PR, thanks again! |
Not sure about the failing linter CI step. Should I look into it or is it something with the CI ? The error does not look like specific to this PR... |
The error seems to be related to ESLint in the CI. I you want to take a look at it with another PR, you are more than welcome, thanks Loic! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. ES lint error is handled in #5722
e762007
to
5cc263b
Compare
Now that new admin allow for searching them, we had to allow name attrribute to be searchable via ransack
5cc263b
to
55ec39e
Compare
I just rebased branch from main after the linting CI error has been fixed in #5721. CI should be green here after that. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5718 +/- ##
==========================================
+ Coverage 88.84% 88.86% +0.02%
==========================================
Files 704 705 +1
Lines 16757 16789 +32
==========================================
+ Hits 14887 14919 +32
Misses 1870 1870 ☔ View full report in Codecov by Sentry. |
Summary
This PR migrates the creation of new shipping categories to the new admin interface.
It follows the same kind of work done for Tax categories in #5674
There is no issue but a project item that I cannot move or comment, probably due to permission issues. https://github.com/orgs/solidusio/projects/12/views/1?filterQuery=xs&pane=issue&itemId=52590587
I also fixed searching shipping categories. This was a feature not present on old admin and by introducing new UI, and capability to search them, it was missing a ransack config to allow searching them by name.
Screen.Recording.2024-04-10.at.13.00.01.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: