Add template variants scope #5866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
mamhoff
force-pushed
the
template-variants
branch
from
5530edf
to
cc441df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5866 +/- ##
=======================================
Coverage 89.24% 89.24%
=======================================
Files 754 754
Lines 17533 17536 +3
=======================================
+ Hits 15647 15650 +3
Misses 1886 1886 ☔ View full report in Codecov by Sentry. |
kennyadsl
reviewed
Oct 9, 2024
mamhoff
force-pushed
the
template-variants
branch
from
cc441df
to
1938a53
Compare
mamhoff
force-pushed
the
template-variants
branch
from
1938a53
to
1b5507d
Compare
All products have variants, but not all variants can actually be sold. When a product has option types, the sellable variants are those that are assigned to option values, whereas the "master" variant is only there as a template for other variants to be created. I'm using the language "template variant" because "master variant" because it more closely matches what the `is_master` flag on the Spree::Variant actually does.
Currently, one can add template variants to one's cart, but that should not be possible. This commit makes sure that the variant search won't return template variants.
mamhoff
force-pushed
the
template-variants
branch
from
1b5507d
to
6b4d76d
Compare
jarednorman
approved these changes
Oct 9, 2024
MadelineCollier
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This introduces logic that removes the ability to add template ("master") variants to admin carts.
When a product has option types and option values, it can have multiple variants. It will also have a variant with the
is_masterflag set totrue, but that variant will not be sellable in the frontend. For a t-shirt that has the option types "Size" and "Color", for example, the master variant would not have a color and not have a size - thus it would be impossible to actually buy.However, for items that don't have option types - single-variant products - the variant with the
is_masterflag is actually what customers would add to their cart. The logic in this PR respects that.If your store uses
.where(is_master: false)to find out whether something is sellable, you can now instead do.sellable.Checklist
The following are mandatory for all PRs:
The following are not always needed: