Do not use solidus_frontend to test extension test app generator #5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidus_frontend is [EOL since 2024-10-21](https://github.com/solidusio/solidus_frontend?tab=readme-ov-file#-warning) using it to test the extension:test_app rake task is not working since it is not compatible with latest Rails, Ruby and Solidus. Since we already have a test for the extension test app generator we can check for it's dummy app existence instead.
github-actions
bot
added
the
changelog:repository
jarednorman
approved these changes
Oct 29, 2024
adammathys
approved these changes
Oct 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5888 +/- ##
=======================================
Coverage 89.57% 89.57%
=======================================
Files 782 782
Lines 17965 17965
=======================================
Hits 16092 16092
Misses 1873 1873 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solidus_frontend is EOL since 2024-10-21 using it to test the extension:test_app rake task is not working since it is not compatible with latest Rails, Ruby and Solidus.
Since we already have a test for the extension test app generator we can check for it's dummy app existence instead.
Extracted from #5843