Improve solidus_promotions/MIGRATING.md #5895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:repository
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5895 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 783 783
Lines 17994 17994
=======================================
Hits 16113 16113
Misses 1881 1881 ☔ View full report in Codecov by Sentry. |
tvdeyen
reviewed
Nov 4, 2024
promotions/MIGRATING.md
Outdated
| In order to do so, first make sure you have no ineligible promotion adjustments left in your database: | ||
|
|
||
| ```rb | ||
| >> Spree::Adjustment.where(eligible: true) |
There was a problem hiding this comment.
Needs to be
Spree::Adjustment.where(eligible: false)
There was a problem hiding this comment.
maybe write and mention a rake task
mamhoff
force-pushed
the
improve-promotion-migration-doc
branch
from
06b7535
to
a97344d
Compare
This commit adds an introductory section telling the reader how the migration process works. It also adds a last section telling the reader to remove any ineligible adjustments from their database. Lastly, it corrects the location of Spree configuration from the `solidus_promotions` initializer to the `spree.rb` initializer.
mamhoff
force-pushed
the
improve-promotion-migration-doc
branch
from
a97344d
to
ba51ba1
Compare
jarednorman
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds an introductory section telling the reader how the migration process works.
It also adds a last section telling the reader to remove any ineligible adjustments from their database.
Lastly, it corrects the location of Spree configuration from the
solidus_promotionsinitializer to thespree.rbinitializer.