Feat(Admin): Dynamic routing proxies #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
dynamic-routing-proxies
branch
2 times, most recently
from
28b50f2
to
f5e1b1f
Compare
tvdeyen
approved these changes
Nov 15, 2024
admin/app/components/solidus_admin/layout/navigation/item/component.rb
Outdated
Show resolved
Hide resolved
Merged
This commit allows the menu of the new admin to accomodate routes from other engines than solidus backend and solidus admin. This is needed for `solidus_promotions`, which is built as a separate Rails Engine, but it is also convenient for `solidus_paypal_commerce_platform` or even for integrating gems like AlchemyCMS lateron. Co-Authored-By: [email protected]
mamhoff
force-pushed
the
dynamic-routing-proxies
branch
from
f5e1b1f
to
c1e4f12
Compare
Not directly, it allows fixes that are present in #5934 |
jarednorman
approved these changes
Nov 17, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5933 +/- ##
==========================================
- Coverage 89.53% 87.81% -1.73%
==========================================
Files 782 476 -306
Lines 17982 11656 -6326
==========================================
- Hits 16101 10236 -5865
+ Misses 1881 1420 -461 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the menu of the new admin to accomodate routes from other engines than solidus backend and solidus admin. This is needed for
solidus_promotions, which is built as a separate Rails Engine, but it is also convenient forsolidus_paypal_commerce_platformor even for integrating gems like AlchemyCMS lateron.The following are not always needed: