Move line_item_comparison_hooks config to Spree::Config #6050
+73
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
tvdeyen
reviewed
Dec 23, 2024
mamhoff
force-pushed
the
configure-line-item-comparison-hooks-in-config
branch
from
ddb140c to
49c44a5
Compare
mamhoff
force-pushed
the
configure-line-item-comparison-hooks-in-config
branch
from
49c44a5 to
05d4196
Compare
Setting line item comparison hooks in a `config.to_prepare` block will currently autoload the Spree::Order model (and subsequently any model referenced in that class definition), slowing down the boot process in development mode (when we want our app/ directory to be autoloaded. This moves setting those hooks to Spree::Config, which is already loaded by the time initializers run. This allows us to move code out of `config.to_prepare` hooks, and stop the order class from being inadvertently eager loaded.
mamhoff
force-pushed
the
configure-line-item-comparison-hooks-in-config
branch
from
05d4196 to
81bf6f6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6050 +/- ##
==========================================
+ Coverage 86.62% 88.68% +2.06%
==========================================
Files 511 829 +318
Lines 11809 18012 +6203
==========================================
+ Hits 10229 15974 +5745
- Misses 1580 2038 +458 ☔ View full report in Codecov by Sentry. |
jarednorman
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting line item comparison hooks in a
config.to_prepareblock will currently autoload the Spree::Order model (and subsequently any model referenced in that class definition), slowing down the boot process in development mode (when we want our app/ directory to be autoloaded.This moves setting those hooks to Spree::Config, which is already loaded by the time initializers run. This allows us to move code out of
config.to_preparehooks, and stop the order class from being inadvertently eager loaded.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: