Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect Spree.user_class' table name in metadata migration #6157

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Feb 24, 2025

Summary

A Spree.user_class might have a different table_name than spree_users. In order to support this we need to ask the class for it's table_name.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen requested a review from a team as a code owner February 24, 2025 08:32
@tvdeyen tvdeyen added the backport-v4.5 Backport this pull-request to v4.5 label Feb 24, 2025
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Feb 24, 2025
@tvdeyen tvdeyen added type:bug Error, flaw or fault changelog:solidus_core Changes to the solidus_core gem and removed changelog:solidus_core Changes to the solidus_core gem labels Feb 24, 2025
@fthobe
Copy link
Contributor

fthobe commented Feb 24, 2025

Did we miss that?

A Spree.user_class might have a different table_name than
spree_users. In order to support this we need to ask the
class for it's table_name.
@tvdeyen tvdeyen force-pushed the fix-metadata-users-migration branch from 5177ad9 to 1bcdfe4 Compare February 24, 2025 10:11
@tvdeyen tvdeyen enabled auto-merge February 24, 2025 10:12
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (2678765) to head (1bcdfe4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6157      +/-   ##
==========================================
+ Coverage   86.64%   88.81%   +2.16%     
==========================================
  Files         514      835     +321     
  Lines       11891    18152    +6261     
==========================================
+ Hits        10303    16121    +5818     
- Misses       1588     2031     +443     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen
Copy link
Member Author

tvdeyen commented Feb 24, 2025

Did we miss that?

Yap

@tvdeyen tvdeyen merged commit eca889d into solidusio:main Feb 24, 2025
23 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
v4.5

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.5 Backport this pull-request to v4.5 changelog:solidus_core Changes to the solidus_core gem type:bug Error, flaw or fault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants