Updates Italian translations #62
Conversation
|
#64 fixes the build failures. Please rebase once it's landed in |
|
@tvdeyen what do I need to do in order to help this get into the master so that we can use the main gem instead of a fork? |
|
@bosskovic how is your work related to #56? Please
Thanks for your contribution |
|
@bosskovic https://github.com/Xpitality/solidus_i18n/blob/e9070d890c1e5bfd4518814301f96b873fd6129f/config/locales/it.yml#L5 https://github.com/Xpitality/solidus_i18n/blob/e9070d890c1e5bfd4518814301f96b873fd6129f/config/locales/it.yml#L317 |
|
@bosskovic Would you mind squashing your commits and rebasing on master? |
There was a problem hiding this comment.
Thanks! Looks like we are missing a lot of keys in it so this is very useful.
But i saw some things that need to be fixed to keep the file to a good level.
I've added comments on some lines, especially on removed keys, keys that are changed to something that doesn't seem better to me, and keys that are not coherent with similar ones.
Fixing the whole file following those advices, and then squashing and rebasing it would be super great!
| attributes: | ||
| spree/order_cancellations: | ||
| quantity: Quantà | ||
| state: Status |
There was a problem hiding this comment.
i think we usually use "Stato" for state?
| activerecord: | ||
| attributes: | ||
| spree/address: | ||
| address1: Indirizzo | ||
| address2: Indirizzo (agg.) | ||
| city: Città | ||
| country: Nazione |
| firstname: Nome | ||
| lastname: Cognome | ||
| phone: Telefono | ||
| state: Provincia |
| activemodel: | ||
| attributes: | ||
| spree/order_cancellations: | ||
| quantity: Quantà |
| spree/order_cancellations: | ||
| quantity: Quantà | ||
| state: Status | ||
| shipment: Trasporto |
There was a problem hiding this comment.
I think shipment is usually "Spedizione".
We ned to keep coherence between translations
| spree/credit_card: | ||
| attributes: | ||
| base: | ||
| card_expired: "La carta è escaduta" |
| spree/reimbursement: | ||
| attributes: | ||
| base: | ||
| return_items_order_id_does_not_match: One or more of the return items specified do not belong to the same order as the reimbursement. |
| success: "Autorizzato correttamente dall'account %{kind}" | ||
| unlocks: | ||
| send_instructions: Riceverai un'email con le istruzioni per sbloccare il tuo account entro pochi minuti. | ||
| unlocked: Il tuo account è stato sbloccato con successo. Hai effettuato il login. | ||
| user_passwords: | ||
| user: | ||
| cannot_be_blank: La password non può essere vuota. | ||
| cannot_be_blank: Devi inserire una password valida. |
There was a problem hiding this comment.
👎 I'd stay with the old one
| accepted: Accettato | ||
| account: Account | ||
| account_updated: Account aggiornato | ||
| action: Azione | ||
| actions: | ||
| add: Add |
| cancel: Annulla | ||
| continue: Continua | ||
| create: Crea | ||
| delete: Delete |
There was a problem hiding this comment.
This is also "Elimina" in italian i think...
|
Hi! It was easier for me to create a new pull request: #90 I based it on the most recent master. I used the en.yml from solidus core as reference (added the missing keys and fixed the order of existing keys to match that in en.yml as much as possible). I took the values from our Italian translations and the existing it.yml of solidus_i18n repo. In it.yml now there are lot more keys then in en.yml of solidus core. Possibly many are obsolete, but I did not remove any of them myself. Please note that I am not an Italian speaker, so I did not (nor am I able to) add any new translations, I just used those that were already there and picked and chose between the two when there were variants (one being the existing it.yml translations and the other those translated by our team in the past year). Please take a look and merge it soon, because it is quite time consuming doing these compares and resolving conflicts. |
|
I'd like to emphasise again that I changed the order of keys in it.yml of solidus_i18n to match the order of keys in en.yml of solidus_core. Thus many keys will appear to be deleted in the diff, but if you look carefully, they are added back at some other place. it.yml now contains all keys from en.yml + some other (probably mostly obsolete). |
|
What's the status on this? I wanted to contribute, but I don't understand... I don't want to do the work twice |
|
I created another PR with the current translations #138 |
|
Closed in favour of #90 and #138 . Thanks for your work @bosskovic ! |
We updated Italian translations by adding missing key-value pairs from en.yml and translating the values to Italian. We did not remove any keys that were previously present, so it.yml now has more keys then en.yml of solidus core.
We tested the translations only by manually navigating the app and we made sure that no translations were missing by raising exceptions for missing translations (
config.action_view.raise_on_missing_translations = true)In addition to this we updated the Italian localization files for other solidus gems and will send pull requests to their repos.