-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MiNAA v1.1.0 #13
Merged
MiNAA v1.1.0 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update develop
Arnaud's suggestions
… feature/webapp_adaptation
pull direct JOSS revisions
…emuslab/minaa into feature/webapp_adaptation
Feature/webapp adaptation
Feature/bio_similarity
Feature/similarity_threshold
crsl4
previously approved these changes
Jan 17, 2024
crsl4
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiNAA v1.1.0
Overview
This update brings a large number of peripheral changes to MiNAA which enhance user experience and understanding, code readability, and the ability to interface with other programs. Core functionality has not changed at all. Any commands and inputs previously run on version 1.0.1 will work and output the same results.
Feature: Webapp Adaptation [PR]
The bulk of the functional changes in this update are the addition of arguments for interfacing with the R Shiny app (in development). In addition, slight refactoring was made across file_io.cpp, making naming conventions more uniform and select functions a bit more generic.
New Arguments:
Feature: Biological Similarity Conversion [PR]
The new optional argument enables the user to input a biological similarity matrix if that's more convenient. Previously the bioligical input was required to be a cost matrix.
New Argument:
Feature: Similarity Threshold [PR]
For computational complexity reasons, our alignment algorithm finds a complete (rather than partial) matching between two networks. This means that certain nodes may be matched by the algorithm, even if they obviously bear no relation (have a very low similarity). Hence, the value of the argument added below. This is completely optional, and the default value of 0 keeps the same logic that existed previously.
New Argument
The other notable addition (and source of bloat) on this PR is the rewrite to the examples. All have been pulled out of the root README in favor of deeper explanation with actual inputs (using real-world data) and outputs in the example/ folder. The previous single example in that folder has been removed, as it was essentially a duplicate of one single network pair from the Simulation data. This has no impact on functionality.
Additional Changes
No additional functional changes were made, just cosmetic updates causing more diff bloat.
example/
was renamed toexamples/
, reindexing 25 files and thousands of lines.