Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AE-1923: Mark older käytönvalvonta toimenpidetypes that should have comments as allowing comments in db #32

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

Juholei
Copy link
Collaborator

@Juholei Juholei commented Jan 4, 2024

AE-1923:

Mark older käytönvalvonta toimenpidetypes that should have comments as allowing comments in db

  • Previously there has been a logic in frontend to allow comments when there are no document templates attached to the toimenpidetype
  • Now we change the the older toimenpidetypes to use the flag allow_comments that is saved to database
  • Toimenpidetypes changed now are "Valvonnan aloitus", "Käskypäätös" and "Valvonnan lopetus"

Remove condition in käytönvalvonta new-toimenpide-dialog to show commenting when there are no document template

  • Commenting is now only allowed for toimenpidetypes that have it configured to be allowed in vk_toimenpidetype db table

…omments as allowing comments in db

- Previously there has been a logic in frontend to allow comments when there are no document templates attached to the toimenpidetype
- Now we change the the older toimenpidetypes to use the flag allow_comments that is saved to database
- Toimenpidetypes changed now are "Valvonnan aloitus", "Käskypäätös" and "Valvonnan lopetus"
…show commenting when there are no document template

- Commenting is now only allowed for toimenpidetypes that have it configured to be allowed in vk_toimenpidetype db table
@Juholei Juholei marked this pull request as ready for review January 4, 2024 12:53
@Juholei Juholei changed the title AE-1923: Mark older käytönvalvonta toimenpidetypes that should have c… AE-1923: Mark older käytönvalvonta toimenpidetypes that should have comments as allowing comments in db Jan 4, 2024
@Juholei Juholei merged commit 511ebd7 into main Jan 5, 2024
16 checks passed
@Juholei Juholei deleted the feature/AE-1923 branch January 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants