-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AE-2164: New energiatodistus signing UI #355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc606b7
to
4bed9d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oisko demo?
etp-front/src/pages/energiatodistus/signing/SigningDialog.test.mjs
Outdated
Show resolved
Hide resolved
2e64de8
to
bb90969
Compare
etp-front/src/pages/energiatodistus/signing/SigningDialog.test.js
Outdated
Show resolved
Hide resolved
solita-juhohaa
approved these changes
Apr 23, 2024
28c08a9
to
702c773
Compare
…ont project to type module in package.json - Configuration files that are common js instead of es modules renamed to cjs to support this change - Configure webpack to not require file extensions in imports
…polyfill fetch in component tests
…ithout mpollux connection
…ironment and allow it outside production
- Preserves current functionality in production
…n queries to use getByRole - Without open attribute the dialog was not visible in tests - Other queries still found the elements but getByRole checks that they are accessible and as they weren't visible they weren't accessible
…s now treated as es modules as a whole
…gningDialog tests
…st.js in cases where calls were only querying things
702c773
to
b4a19ce
Compare
bf3ed27
to
634ada3
Compare
solita-juhohaa
approved these changes
Apr 25, 2024
solita-antti-mottonen
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.