Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AE-2164: New energiatodistus signing UI #355

Merged
merged 49 commits into from
Apr 29, 2024
Merged

AE-2164: New energiatodistus signing UI #355

merged 49 commits into from
Apr 29, 2024

Conversation

Juholei
Copy link
Collaborator

@Juholei Juholei commented Apr 16, 2024

No description provided.

@Juholei Juholei force-pushed the feature/AE-2164 branch 11 times, most recently from dc606b7 to 4bed9d5 Compare April 19, 2024 09:52
@Juholei Juholei marked this pull request as ready for review April 19, 2024 12:32
Copy link
Contributor

@solita-antti-mottonen solita-antti-mottonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oisko demo?

@Juholei Juholei force-pushed the feature/AE-2164 branch 3 times, most recently from 2e64de8 to bb90969 Compare April 23, 2024 06:08
Juholei added 19 commits April 24, 2024 13:33
- Preserves current functionality in production
…n queries to use getByRole

- Without open attribute the dialog was not visible in tests
- Other queries still found the elements but getByRole checks that they are accessible and as they weren't visible they weren't accessible
…st.js in cases where calls were only querying things
@Juholei Juholei merged commit 8442f1f into main Apr 29, 2024
16 checks passed
@Juholei Juholei deleted the feature/AE-2164 branch April 29, 2024 06:01
@Juholei Juholei restored the feature/AE-2164 branch April 29, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants