Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ae 2089 margin adjust #39

Merged
merged 8 commits into from
Jan 9, 2024
Merged

Feature/ae 2089 margin adjust #39

merged 8 commits into from
Jan 9, 2024

Conversation

muep
Copy link
Contributor

@muep muep commented Jan 8, 2024

No description provided.

@@ -86,7 +86,7 @@
on:submit|preventDefault={saveKayttaja}
on:input={setDirty}
on:change={setDirty}>
<div class="flex lg:flex-row flex-col py-4 -mx-4 my-4">
<div class="flex lg:flex-row flex-col py-4 lg:-mx-4 my-4">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Näitä -mx-4 -classeja oli käytetty aika paljon, ja niillä sai nyt monessa paikkaa kiusallisen vaakavierityksen, kun reunasta otettiin marginaalia pois.

<Breadcrumb {whoami} {idTranslate} location={$location} />
</div>
</div>
<section class="content">
<section class="content px-2 lg:px-10">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tästä tulee oikeastaan se merkittävin vaikutus. Muut jutut ovat sitten sopeuttamista toimimaan tämän kanssa nätisti.

Copy link
Collaborator

@Juholei Juholei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Katsotaan muutokset yhdessä läpi visuaalisesti vertaillen

@muep muep merged commit 0f18e4f into main Jan 9, 2024
16 checks passed
@muep muep deleted the feature/ae-2089-margin-adjust branch January 9, 2024 11:50
@muep muep restored the feature/ae-2089-margin-adjust branch January 9, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants