This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
AE-1987: käskypäätös / varsinainen päätös toimenpide changes #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipient-answered', 'answer-commentary-fi', 'answer-commentary-sv', 'statement-fi', 'statement-sv' to be osapuoli-specific - Preliminary UI changes to support this change included, will be rethought later
Juholei
force-pushed
the
feature/AE-1987
branch
from
346c653 to
70654b2
Compare
…ional in schema and hidden in UI for käskypäätös / varsinainen päätös toimenpidetype
Juholei
force-pushed
the
feature/AE-1987
branch
from
7561f59 to
2bd1fb7
Compare
…, statement-sv to null if recipient-answered is false when sending toimen pide to backend
… statement fields when there is no document for osapuoli, move their original schema under osapuoli-specific-data
Juholei
force-pushed
the
feature/AE-1987
branch
from
885b1fc to
7ef263f
Compare
Juholei
commented
Oct 16, 2023
src/pages/valvonta-kaytto/new-actual-decision-toimenpide.svelte
Outdated
Show resolved
Hide resolved
Juholei
commented
Oct 16, 2023
Juholei
force-pushed
the
feature/AE-1987
branch
from
75f2bf7 to
67289cc
Compare
Juholei
changed the title
|
Joku erotin loppuun ennen mainintaa manuaalisesta toimittamisesta olisi hyvä |
Juholei
commented
Oct 17, 2023
src/pages/valvonta-kaytto/new-actual-decision-toimenpide.svelte
Outdated
Show resolved
Hide resolved
… päätös if the osapuoli doesn't have document
- All osapuoli specific fields are under the heading with the osapuoli name - Separate osapuolitable removed as unnecessary
… varsinainen päätös toimenpide ui
… in the preview api call for käskypäätös / varsinanen päätös document - If other osapuolis are still missing the data, it's now possible to preview the document for an osapuoli that has all the required data filled in
…view for each osapuoli - Previously the errors were visible only in the top of the dialog so they weren't visible most of the time
…xForOsapuoli - Matches the current functionality and usage better
Juholei
force-pushed
the
feature/AE-1987
branch
from
9636ee3 to
141fe48
Compare
…-toimenpide view to a new Error component
Juholei
force-pushed
the
feature/AE-1987
branch
from
7e2a71f to
3ebbd2a
Compare
…ated for preview - Otherwise the partial data was validated agains a full schema that expected all osapuolis to be present
Juholei
force-pushed
the
feature/AE-1987
branch
from
3ebbd2a to
fbfb995
Compare
… the fields in käskypäätös / varsinainen päätös form
solita-antti-mottonen
approved these changes
Oct 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move käskypäätös / varsinainen päätös toimenpide fields 'recipient-answered', 'answer-commentary-fi', 'answer-commentary-sv', 'statement-fi', 'statement-sv' to be osapuoli-specific
New UI where all the osapuoli specific fields are organized by osapuoli