MQTT ha discovery is incomplete with multiple inverters due to nonunique ids #63 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made serial a local variable to the function where mqtt messages where being created. Also included inverter serial as part of the mqtt data packet being sent. (not strictly necessary but helped with easy debugging)
nagydavid
requested changes
Sep 20, 2022
| my %config_data = ( | ||
| device => { | ||
| identifiers => [ | ||
| $mqtt_serial, | ||
| $mqtt_serial_HA, |
There was a problem hiding this comment.
why change the variable name?
There was a problem hiding this comment.
$mqtt_serial_HA is not a name change as such, its an entirely new local variable to ensure that this one was being used (and correctly assigned) and not the original $mqtt_serial.
I'm still not 100% on whether this is the best way to do this, we shouldn't really need 2 serial variables, this works and it preserved the fidelity of the mqtt publish commands which I didn't want to change.
fixing indents, originally working on this in notepad++ and used tabs for the spacing as typically that i what i would have used in c#/c++. it wasnt obvious that the document was indented using spaces in notepad++. rededited in vscode and the issue became clear.
|
done all requested indentation changes. Name thing is something you may wish to delve into. |
|
@nagydavid Any help needed on this one? |
|
yes please, if you have time. I am very busy with my work coding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mqtt inverter serial number update for multiple inverters
made serial a local variable to the function where mqtt messages where being created. Also included inverter serial as part of the mqtt data packet being sent. (not strictly necessary but helped with easy debugging)