Deprecate AuthConfig pluginAuth in extauth.proto (#10258)

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Rachael Graham <[email protected]>
solo-io · Nov 6, 2024 · 90f91ad · 90f91ad
1 parent 202a645
commit 90f91ad
Show file tree

Hide file tree

Showing 6 changed files with 1,362 additions and 1,349 deletions.
diff --git a/changelog/v1.18.0-beta33/deprecate-AuthConfig-pluginAuth.yaml b/changelog/v1.18.0-beta33/deprecate-AuthConfig-pluginAuth.yaml
@@ -0,0 +1,5 @@
+changelog:
+- type: NON_USER_FACING
+  description: Mark AuthConfig spec.configs.pluginAuth as deprecated in favor of passThroughAuth.
+  issueLink: https://github.com/solo-io/solo-projects/issues/6961
+  resolvesIssue: false
diff --git a/...-io/gloo/projects/gloo/api/v1/enterprise/options/extauth/v1/extauth.proto.sk.md b/...-io/gloo/projects/gloo/api/v1/enterprise/options/extauth/v1/extauth.proto.sk.md
diff --git a/projects/gloo/api/v1/enterprise/options/extauth/v1/extauth-internal.proto b/projects/gloo/api/v1/enterprise/options/extauth/v1/extauth-internal.proto
@@ -700,7 +700,7 @@ message ExtAuthConfig {
             BasicAuth basic_auth = 4;
             BasicAuthInternal basic_auth_internal = 17;
             ApiKeyAuthConfig api_key_auth = 5;
-            AuthPlugin plugin_auth = 6;
+            AuthPlugin plugin_auth = 6 [deprecated = true];
             OpaAuthConfig opa_auth = 7;
             Ldap ldap = 8 [deprecated = true];
             // Used for LDAP configurations that need service account credentials saved in a secret.

diff --git a/projects/gloo/api/v1/enterprise/options/extauth/v1/extauth.proto b/projects/gloo/api/v1/enterprise/options/extauth/v1/extauth.proto
@@ -50,7 +50,7 @@ message AuthConfig {
             OAuth oauth = 2 [deprecated = true];
             OAuth2 oauth2 = 8;
             ApiKeyAuth api_key_auth = 4;
-            AuthPlugin plugin_auth = 5;
+            AuthPlugin plugin_auth = 5 [deprecated = true];
             OpaAuth opa_auth = 6;
             Ldap ldap = 7;
             // This is a "dummy" extauth service which can be used to support multiple auth mechanisms with JWT authentication.
@@ -247,6 +247,7 @@ message CustomAuth {
     string name = 2;
 }
 
+// **Deprecated**: The pluginAuth config type is deprecated and will be removed in a future release. Use passThroughAuth instead.
 message AuthPlugin {
     // Name of the plugin
     string name = 1;