Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix route reports for custom backends #10361

Merged
merged 15 commits into from
Nov 25, 2024
Merged

Conversation

stevenctl
Copy link

@stevenctl stevenctl commented Nov 15, 2024

This message is wrong; plugin backend types should't write this status.

    - lastTransitionTime: "2024-11-15T19:38:52Z"
      message: invalid backend type provided
      observedGeneration: 6
      reason: InvalidKind
      status: "False"
      type: ResolvedRefs

Copy link

@danehans danehans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits. Otherwise LGTM.

@danehans
Copy link

danehans commented Nov 25, 2024

The Kubernetes Tests / End-to-End (cluster-six) job is failing due to:

Gloo was successfully uninstalled.
--- FAIL: TestK8sGateway (229.49s)
    --- PASS: TestK8sGateway/HTTPRouteServices (89.12s)
        --- PASS: TestK8sGateway/HTTPRouteServices/TestConfigureHTTPRouteBackingDestinationsWithService (46.65s)
        --- PASS: TestK8sGateway/HTTPRouteServices/TestConfigureHTTPRouteBackingDestinationsWithServiceAndWithoutTCPRoute (42.47s)
    --- FAIL: TestK8sGateway/TCPRouteServices (65.56s)
        --- FAIL: TestK8sGateway/TCPRouteServices/TestConfigureTCPRouteBackingDestinationsWithMultiServices (65.56s)

#10398 may help with this flake. I am rerunning the failed job.

@danehans
Copy link

@stevenctl make generate-changelog and mv changelog/v1.18.0-rc2/custom-be-route-report.yaml to the newly generated changelog to fix the failing changelog-bot job. cc: @sam-heilbron

@danehans danehans requested a review from puertomontt November 25, 2024 21:21
@stevenctl stevenctl enabled auto-merge (squash) November 25, 2024 22:36
@stevenctl stevenctl merged commit b937894 into solo-io:main Nov 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants