Don't export ValidationSplitWebhook test

[sheidkamp]

Description

Create a new SuiteRunner for the ValidationTests which does not include the split validation test, which
fails when imported by other projects. k8sgateway#10374 created to
track a fix that will allow tests that update Helm values to be exported.

Can't use Skip in the tests because the e2e.MustTestHelper(ctx, testInst) command in the suite constructor fails due to not finding a locally built gloo helm chart

This test should be safe to skip because it is not testing any EE or Helm specific functionality, and is more of an integration/smoke test for the split webhook. The Helm upgrades performed are to update webhook values, not to test anything Helm related.

Testing

Local tests - ValidationSplitWebhook tests are still running: https://github.com/solo-io/gloo/actions/runs/11974993999/job/33390398462#step:7:14910

In EE:
Pull in OSS branch and run:

go clean -testcache; GOLANG_PROTOBUF_REGISTRATION_CONFLICT=ignore go test -v -timeout 600s ./test/kubernetes/e2e/tests -run  ^TestOssFeatures$/^OssValidationStrict$

and get results:

--- PASS: TestOssFeatures (136.74s)
    --- PASS: TestOssFeatures/OssValidationStrict (136.74s)
        --- PASS: TestOssFeatures/OssValidationStrict/ValidationStrictWarnings (39.56s)
            --- PASS: TestOssFeatures/OssValidationStrict/ValidationStrictWarnings/TestInvalidUpstreamMissingPort (17.09s)
            --- PASS: TestOssFeatures/OssValidationStrict/ValidationStrictWarnings/TestRejectsInvalidVSMissingUpstream (0.16s)
            --- PASS: TestOssFeatures/OssValidationStrict/ValidationStrictWarnings/TestVirtualServiceWithSecretDeletion (22.31s)
        --- PASS: TestOssFeatures/OssValidationStrict/ValidationRejectInvalid (25.18s)
            --- PASS: TestOssFeatures/OssValidationStrict/ValidationRejectInvalid/TestRejectTransformation (2.42s)
            --- PASS: TestOssFeatures/OssValidationStrict/ValidationRejectInvalid/TestRejectsInvalidGatewayResources (0.15s)
            --- SKIP: TestOssFeatures/OssValidationStrict/ValidationRejectInvalid/TestRejectsInvalidRatelimitConfigResources (0.00s)
            --- PASS: TestOssFeatures/OssValidationStrict/ValidationRejectInvalid/TestRejectsInvalidVSMethodMatcher (0.17s)
            --- PASS: TestOssFeatures/OssValidationStrict/ValidationRejectInvalid/TestRejectsInvalidVSTypo (0.15s)
            --- PASS: TestOssFeatures/OssValidationStrict/ValidationRejectInvalid/TestVirtualServiceWithSecretDeletion (22.29s)
PASS

(TestOssFeatures/OssValidationStrict/ValidationSplitWebhook is not present)

[solo-changelog-bot]

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7256

[jenshu]

why not leave the exported one ValidationStrictSuiteRunner so s-p import doesn't need to change?

[jenshu]

and the new one can be ValidationStrictSuiteRunnerNotExported or something?

[github-actions]

Visit the preview URL for this PR (updated for commit 060d445):

https://gloo-edge--pr10394-sheidkamp-dont-expor-ijctzmml.web.app

_{(expires Sat, 30 Nov 2024 04:11:30 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 77c2b86e287749579b7ff9cadb81e099042ef677}