Feat/large validation

[nfuden]

Note this is entirely ripped from #10296

Description

To address an issue with large configs passed as arguments causing a arguments to long error during validation; This PR adjusts how the config is provided to Envoy. The config is now fed to the process via STDIN and the --config-yaml is set to the file descriptor for STDIN.

Code changes

• Switch to STDIN for injecting the config during validation
• Pass CLUSTER_NAME to kube2e test running
• Adjusted instructions for running kube3e tests locally.
• Added make target for kind setup
• Increased timeout of validation webhook in tests and added note to docs

Context

A customer with a large config reported the error.

Interesting decisions

Initially there were discussions about saving a file inside of the container, but concerns about read-only root filesystems were raised. A volume would address that issue, but is a more complex solution. To avoid the need for a volume in some cases, I opted to use STDIN to provide the config to the program and read the STDIN FD to the config.

Testing steps

I've applied the large config yaml in the test with and without the fix confirming that is was broken and is now fixed.

% make kind-setup
% helm upgrade --install -n gloo-system --create-namespace gloo ./_test/gloo-1.0.0-ci1.tgz --values ./test/kubernetes/e2e/tests/manifests/common-recommendations.yaml
% make -B kind-reload-gloo
% kubectl create namespace full-envoy-validation-test
% kubectl apply -f test/kubernetes/e2e/features/validation/testdata/valid-resources/large-configuration.yaml

Notes for reviewers

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[solo-changelog-bot]

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7089

[github-actions]

Visit the preview URL for this PR (updated for commit 807a1d1):

https://gloo-edge--pr10417-feat-large-validatio-lmx29blq.web.app

_{(expires Mon, 09 Dec 2024 20:20:36 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 77c2b86e287749579b7ff9cadb81e099042ef677}

[sam-heilbron]

looking good!

[sam-heilbron]

I like this! I wonder if we could make this information consumable to create insights on, so users could see if their configuration was growing over time.

[nfuden]

I think this might not be the right place but I like the idea. Perhaps higher up in translation we take our final output there to emit a metric?

[sam-heilbron]

Any reason this is false? I imagined that we could test the fullEnvoyValidation even with allowWarnings=true

[nfuden]

We could, this doesnt change the option just removes the comment

[sam-heilbron]

LGTM!

Can you update the PR body to just add some context to it?