Adds ReferenceGrant Tests for TCPRoute #10419

danehans · 2024-12-02T00:53:20Z

Adds ReferenceGrant tests for TCPRoute coverage.

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7309
resolves e2e: SingleServiceTCPRoute Test Case #10434

danehans · 2024-12-02T00:54:00Z

Reviewer note: Only review commit 1a1430b since this PR requires #10418.

github-actions · 2024-12-02T01:09:59Z

Visit the preview URL for this PR (updated for commit 7425d74):

https://gloo-edge--pr10419-issue-10414-issue-73-vfi1nodh.web.app

_{(expires Thu, 12 Dec 2024 15:13:47 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 77c2b86e287749579b7ff9cadb81e099042ef677}

changelog/v1.18.0-rc3/issue_7309.yaml

sam-heilbron

Loooking good!

projects/gateway2/translator/testutils/outputs/tcp-routing/invalid-backend.yaml

test/kubernetes/e2e/features/services/tcproute/suite.go

changelog/v1.18.0-rc3/issue_7309.yaml

pkg/schemes/scheme.go

projects/gateway2/query/backendmap.go

projects/gateway2/translator/listener/gateway_listener_translator.go

test/kubernetes/e2e/features/services/tcproute/testdata/multi-backend-service.yaml

lgadban

I think I'm missing how this actually changes the behavior given that the RefGrant support is baked into the query engine

projects/gateway2/translator/listener/gateway_listener_translator.go

solo-changelog-bot · 2024-12-02T20:28:19Z

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7309

danehans · 2024-12-02T20:52:00Z

@lgadban thanks for the review. I resolved your feedback in commit 1718452, PTAL.

lgadban

I think I'm still missing what is the functional change?

It looks like the only difference was the status reporting -- was the previous behavior incorrectly reporting status only?

danehans · 2024-12-03T20:51:21Z

The Kubernetes Tests / End-to-End (cluster-six) CI job failed due to:

--- FAIL: TestK8sGatewayNoValidation (269.72s)
    --- PASS: TestK8sGatewayNoValidation/ListenerOptions (49.36s)
        --- PASS: TestK8sGatewayNoValidation/ListenerOptions/TestConfigureListenerOptions (0.66s)
    --- PASS: TestK8sGatewayNoValidation/RouteOptions (68.27s)
        --- PASS: TestK8sGatewayNoValidation/RouteOptions/TestConfigureInvalidRouteOptionsWithTargetRef (2.29s)
        --- PASS: TestK8sGatewayNoValidation/RouteOptions/TestConfigureRouteOptionsWithFilterExtension (2.58s)
        --- PASS: TestK8sGatewayNoValidation/RouteOptions/TestConfigureRouteOptionsWithMultipleFilterExtensionManualSetup (0.54s)
        --- PASS: TestK8sGatewayNoValidation/RouteOptions/TestConfigureRouteOptionsWithMultipleTargetRefManualSetup (2.56s)
        --- PASS: TestK8sGatewayNoValidation/RouteOptions/TestConfigureRouteOptionsWithTargetRef (0.39s)
        --- PASS: TestK8sGatewayNoValidation/RouteOptions/TestConfigureRouteOptionsWithTargetRefAndFilterExtension (2.67s)
        --- PASS: TestK8sGatewayNoValidation/RouteOptions/TestOptionsMerge (12.06s)
    --- FAIL: TestK8sGatewayNoValidation/VirtualHostOptions (69.00s)
        --- FAIL: TestK8sGatewayNoValidation/VirtualHostOptions/TestConfigureInvalidVirtualHostOptions (22.34s)

Note: The TCPRoute e2e tests passed:

--- PASS: TestK8sGateway (353.90s)
    --- PASS: TestK8sGateway/CRDCategories (0.32s)
        --- PASS: TestK8sGateway/CRDCategories/TestCommonCategory (0.15s)
    --- PASS: TestK8sGateway/TCPRouteServices (190.34s)
        --- PASS: TestK8sGateway/TCPRouteServices/TestConfigureTCPRouteBackingDestinations (190.34s)
            --- PASS: TestK8sGateway/TCPRouteServices/TestConfigureTCPRouteBackingDestinations/SingleServiceTCPRoute (45.80s)
            --- PASS: TestK8sGateway/TCPRouteServices/TestConfigureTCPRouteBackingDestinations/MultiServicesTCPRoute (41.81s)
            --- PASS: TestK8sGateway/TCPRouteServices/TestConfigureTCPRouteBackingDestinations/CrossNamespaceTCPRouteWithReferenceGrant (52.47s)
            --- PASS: TestK8sGateway/TCPRouteServices/TestConfigureTCPRouteBackingDestinations/CrossNamespaceTCPRouteWithoutReferenceGrant (50.26s)
    --- PASS: TestK8sGateway/HTTPRouteServices (89.36s)
        --- PASS: TestK8sGateway/HTTPRouteServices/TestConfigureHTTPRouteBackingDestinationsWithService (46.20s)
        --- PASS: TestK8sGateway/HTTPRouteServices/TestConfigureHTTPRouteBackingDestinationsWithServiceAndWithoutTCPRoute (43.16s)

danehans · 2024-12-03T21:36:41Z

I think I'm still missing what is the functional change?

@lgadban thanks for calling this out. After repro'ing https://github.com/solo-io/solo-projects/issues/7309, I confirmed that the issue was resolved by k8sgateway#10365. I have updated the title and description of this PR.

@sam-heilbron we may still want to consider this a release blocker since it fixes the root cause of the TCPRoute e2e flakes and bumps the GW API CRDs to match CI (v1.1 -> v1.2). I can pull out the commits into separate PRs if needed, LMK.

solo-changelog-bot · 2024-12-04T16:20:27Z

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7309
#10434

pkg/schemes/scheme.go

Signed-off-by: Daneyon Hansen <[email protected]>

danehans · 2024-12-04T20:20:02Z

Rebased since #10435 merged to fix the CI flake affecting this PR.

jenshu

how did you regenerate the crds in projects/gateway2/crds?

danehans · 2024-12-05T15:51:39Z

how did you regenerate the crds in projects/gateway2/crds

The old school way:

$ curl -sLo ./projects/gateway2/crds/gateway-crds.yaml https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.2.0/experimental-install.yaml

danehans · 2024-12-05T17:56:28Z

how did you regenerate the crds in projects/gateway2/crds

@jenshu #10446 adds a target for automating this process, PTAL.

Signed-off-by: Daneyon Hansen <[email protected]> Co-authored-by: Sam Heilbron <[email protected]>

Signed-off-by: Daneyon Hansen <[email protected]> Co-authored-by: Sam Heilbron <[email protected]> Co-authored-by: Jenny Shu <[email protected]>

github-actions bot added the keep pr updated label Dec 2, 2024

danehans requested review from sam-heilbron and nfuden December 2, 2024 00:54

danehans force-pushed the issue_10414_issue_7309 branch from 1a1430b to 8d96b69 Compare December 2, 2024 03:43

nfuden reviewed Dec 2, 2024

View reviewed changes

changelog/v1.18.0-rc3/issue_7309.yaml Outdated Show resolved Hide resolved

sam-heilbron reviewed Dec 2, 2024

View reviewed changes

lgadban reviewed Dec 2, 2024

View reviewed changes

projects/gateway2/translator/listener/gateway_listener_translator.go Outdated Show resolved Hide resolved

projects/gateway2/translator/listener/gateway_listener_translator.go Outdated Show resolved Hide resolved

danehans force-pushed the issue_10414_issue_7309 branch from 8d96b69 to 1718452 Compare December 2, 2024 20:28

danehans force-pushed the issue_10414_issue_7309 branch from 1718452 to 281ace0 Compare December 2, 2024 20:38

danehans requested review from nfuden, lgadban and sam-heilbron December 2, 2024 22:00

danehans force-pushed the issue_10414_issue_7309 branch from 8264aac to 4ca38cf Compare December 2, 2024 23:55

lgadban reviewed Dec 3, 2024

View reviewed changes

danehans changed the title ~~Adds ReferenceGrant Support for TCPRoute~~ Adds ReferenceGrant Tests for TCPRoute Dec 3, 2024

danehans force-pushed the issue_10414_issue_7309 branch from 89b6433 to 1f09c3e Compare December 4, 2024 16:20

danehans force-pushed the issue_10414_issue_7309 branch 2 times, most recently from 3f82175 to 2981cc0 Compare December 4, 2024 16:26

danehans requested a review from lgadban December 4, 2024 17:30

nfuden reviewed Dec 4, 2024

View reviewed changes

pkg/schemes/scheme.go Show resolved Hide resolved

danehans added 3 commits December 4, 2024 12:18

Adds ReferenceGrant Support for TCPRoute

b696c9c

Signed-off-by: Daneyon Hansen <[email protected]>

Uses query pkg to process conditions and refactors e2e tests

6b00609

Signed-off-by: Daneyon Hansen <[email protected]>

Attempts to resolve e2e test flakes

26b4a1d

Signed-off-by: Daneyon Hansen <[email protected]>

danehans added 2 commits December 4, 2024 12:18

Updates TCPRoute e2e to check for CRD and extend assertion timeout

6add4f9

Signed-off-by: Daneyon Hansen <[email protected]>

Bumps GW API CRDs from 1.1 to 1.2

b86fb3f

Signed-off-by: Daneyon Hansen <[email protected]>

danehans force-pushed the issue_10414_issue_7309 branch from 2981cc0 to b86fb3f Compare December 4, 2024 20:18

sam-heilbron approved these changes Dec 4, 2024

View reviewed changes

danehans requested a review from nfuden December 4, 2024 20:20

sam-heilbron added 2 commits December 4, 2024 13:31

Merge branch 'main' into issue_10414_issue_7309

6034342

Merge branch 'main' into issue_10414_issue_7309

7425d74

nfuden approved these changes Dec 5, 2024

View reviewed changes

jenshu approved these changes Dec 5, 2024

View reviewed changes

soloio-bulldozer bot merged commit d0fe477 into main Dec 5, 2024
19 checks passed

soloio-bulldozer bot deleted the issue_10414_issue_7309 branch December 5, 2024 16:15

danehans added a commit that referenced this pull request Dec 5, 2024

Adds ReferenceGrant Tests for TCPRoute (#10419)

df4d5ec

Signed-off-by: Daneyon Hansen <[email protected]> Co-authored-by: Sam Heilbron <[email protected]>

danehans mentioned this pull request Dec 5, 2024

Adds ReferenceGrant Tests for TCPRoute (#10419) #10448

Merged

soloio-bulldozer bot pushed a commit that referenced this pull request Dec 6, 2024

Adds ReferenceGrant Tests for TCPRoute (#10419) (#10448)

2c35b60

Signed-off-by: Daneyon Hansen <[email protected]> Co-authored-by: Sam Heilbron <[email protected]> Co-authored-by: Jenny Shu <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds ReferenceGrant Tests for TCPRoute #10419

Adds ReferenceGrant Tests for TCPRoute #10419

danehans commented Dec 2, 2024 •

edited by solo-changelog-bot bot

Loading

danehans commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024 •

edited

Loading

sam-heilbron left a comment

lgadban left a comment

solo-changelog-bot bot commented Dec 2, 2024

danehans commented Dec 2, 2024

lgadban left a comment •

edited

Loading

danehans commented Dec 3, 2024

danehans commented Dec 3, 2024 •

edited

Loading

solo-changelog-bot bot commented Dec 4, 2024

danehans commented Dec 4, 2024

jenshu left a comment

danehans commented Dec 5, 2024

danehans commented Dec 5, 2024

Adds ReferenceGrant Tests for TCPRoute #10419

Adds ReferenceGrant Tests for TCPRoute #10419

Conversation

danehans commented Dec 2, 2024 • edited by solo-changelog-bot bot Loading

Checklist:

danehans commented Dec 2, 2024 • edited Loading

github-actions bot commented Dec 2, 2024 • edited Loading

sam-heilbron left a comment

Choose a reason for hiding this comment

lgadban left a comment

Choose a reason for hiding this comment

solo-changelog-bot bot commented Dec 2, 2024

danehans commented Dec 2, 2024

lgadban left a comment • edited Loading

Choose a reason for hiding this comment

danehans commented Dec 3, 2024

danehans commented Dec 3, 2024 • edited Loading

solo-changelog-bot bot commented Dec 4, 2024

danehans commented Dec 4, 2024

jenshu left a comment

Choose a reason for hiding this comment

danehans commented Dec 5, 2024

danehans commented Dec 5, 2024

danehans commented Dec 2, 2024 •

edited by solo-changelog-bot bot

Loading

danehans commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024 •

edited

Loading

lgadban left a comment •

edited

Loading

danehans commented Dec 3, 2024 •

edited

Loading