-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eitanya/ai tracing #10427
Eitanya/ai tracing #10427
Conversation
Issues linked to changelog: |
Visit the preview URL for this PR (updated for commit ab4938c): https://gloo-edge--pr10427-eitanya-ai-tracing-c0k8srnf.web.app (expires Mon, 16 Dec 2024 16:54:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Co-authored-by: Nina Polshakova <[email protected]>
Co-authored-by: Nina Polshakova <[email protected]>
projects/gateway2/helm/gloo-gateway/templates/gateway/proxy-deployment.yaml
Show resolved
Hide resolved
pkg/utils/api_conversion/trace.go
Outdated
@@ -117,6 +118,8 @@ func isResourceGateway(resource *gloov1.SourceMetadata_SourceRef) bool { | |||
func gatewayKindsMap() map[string]bool { | |||
return map[string]bool{ | |||
resources.Kind(new(gatewayv1.Gateway)): true, | |||
// https://github.com/solo-io/gloo/blob/main/projects/gateway2/translator/listener/gateway_listener_translator.go#L492 | |||
wellknown.GatewayGroup + wellknown.GatewayKind: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no /
between GatewayGroup and GatewayKind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops 😆
// Optional | ||
// Create separate tracing span for each upstream request if true. And if this flag is set to true, the tracing provider will assume that Envoy | ||
// will be independent hop in the trace chain and may set span type to client or server based on this flag. | ||
bool spawn_upstream_span = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was something about T-mobile and their span name requirement on the request (not related to AI). I don't really know the detail but @ashishb-solo will you have some insight for span name if we are adding open tracing for AI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated, that's about the parent span, this is the span for the upstream call
…into eitanya/ai-tracing
…into eitanya/ai-tracing
Description
This PR introduces the API changes necessary to enable distributing tracing for the AI Gateway
API changes
tracing
config to theGatewayParameteres
AI subsectionservice_name
field to theopen telemetry
tracing configCode changes
Checklist: